Closed Bug 1708077 Opened 3 years ago Closed 3 years ago

[Automated review] Review reports no coverage for RenderCompositorEGL.cpp and RenderCompositorOGL.cpp

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: rmader, Unassigned)

References

Details

Phabricator URL: https://phabricator.services.mozilla.com/D113603

These files are used whenever Webrender is active on Android and Linux/X11 - so I'd assume their coverage is not that bad :)

Any hints here?

Severity: -- → S3
Flags: needinfo?(mcastelluccio)
Priority: -- → P3

You can see the coverage data on https://coverage.moz.tools/#revision=latest&path=gfx%2Fwebrender_bindings&view=directory.

RenderCompositorOGL.cpp appears to be covered. Likely this revision was from back when we were not enabling WebRender in the ccov build.

RenderCompositorEGL.cpp appears not to be covered (is it only used on Android? If so, that would explain it since we don't run ccov on Android yet).

Flags: needinfo?(mcastelluccio) → needinfo?(robert.mader)

RenderCompositorEGL.cpp will be covered extensively once bug 1744060 is closed. In turn, we'll not cover RenderCompositorOGL.cpp any more (which is then a legacy path and unlikely to see new features / much changes).

Flags: needinfo?(robert.mader)
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1744060

I guess we can close this then, we have an explanation for the message.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.