Mute/Unmute icons aren't displayed correctly on Ubuntu 20.04 using system theme
Categories
(Firefox :: Tabbed Browser, defect, P2)
Tracking
()
People
(Reporter: hyacoub, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-tabs-bar] [priority:2b] [proton-uplift])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Ubuntu system theme.png
Affected versions
Firefox 90.0a1
Affected platforms
Ubuntu 20.04 x64
Steps to reproduce
- Open Firefox.
- Play a video on youtube.
- Pin the tab.
- Mute and unmute the tab.
- Observe play/mute icon.
Expected result
Mute/Unmute icons should be displayed correctly on Ubuntu 20.04 using system theme.
Actual Result
Mute/Unmute icons aren't displayed correctly on Ubuntu 20.04 using system theme.
Note
The issue is only reproducible using System theme.
Ubuntu window colors: Light and Standard/
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
This is set at priority:2b and is a CSS change, is that something we should uplift to beta or do we let it ride the 90 train? Thanks
|
Reporter | |
Comment 5•4 years ago
|
||
Verified on Firefox Nightly 90.0a1 (2021-05-04) on Ubuntu 20.04 x64.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 6•4 years ago
|
||
This is a simple CSS change and not uplifting it to beta will introduce extra complexity when uplifting some icons changes (bug 1706084). I think we should reconsider marking this as wontfix for Firefox89.
|
|
||
Comment 7•4 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
This is a simple CSS change and not uplifting it to beta will introduce extra complexity when uplifting some icons changes (bug 1706084). I think we should reconsider marking this as wontfix for Firefox89.
Thanks for the ping, agreed that if uplift is low risk and makes icon changes simpler we should do it.
OK to uplift to 89.
|
||
Comment 9•4 years ago
|
||
Comment on attachment 9219003 [details]
Bug 1708154 - Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast.
Beta/Release Uplift Approval Request
- User impact if declined: Mute and unmute icons in tabs won't appear correct on Linux when using the default theme
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small, well-contained, CSS-only patch that only affects tab badges.
- String changes made/needed: None.
|
|
||
Comment 10•4 years ago
|
||
Comment on attachment 9219003 [details]
Bug 1708154 - Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast.
Low risk, blocks uplifting bug 1706084, , approved for 89 beta 10, thanks.
|
|
||
Comment 11•4 years ago
|
||
| bugherder uplift | ||
|
|
Reporter | |
Comment 12•4 years ago
|
||
Verified as fixed on Ubuntu 20.04 x64 on Firefox 89.0b10.
|
|
Assignee | |
Updated•3 years ago
|
Description
•