Closed Bug 1708251 Opened 4 years ago Closed 4 years ago

Wrong highlighted text on search in PDF

Categories

(Firefox :: PDF Viewer, defect)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 + verified
firefox90 --- verified

People

(Reporter: bdahl, Assigned: bdahl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]:
Visible regression for the PDF viewer.

Depends on: 1708241
Assignee: nobody → bdahl
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1704661

Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte

Beta/Release Uplift Approval Request

  • User impact if declined: When using "highlight all" in the find bar, not all the text will be highlighted in the correct position.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://github.com/mozilla/pdf.js/issues/13292#issue-866739981
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very small CSS change.
  • String changes made/needed: none
Attachment #9218991 - Flags: approval-mozilla-beta?
Flags: qe-verify+

AIUI this was fixed in 90 by bug 1708241?

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

(In reply to Julien Cristau [:jcristau] from comment #5)

AIUI this was fixed in 90 by bug 1708241?

Correct!

QA Whiteboard: [qa-triaged]

Reproduced the issue on Firefox 89 Beta 5.
Verified fixed on latest Nightly 90.0a1 (buildID: 20210505215208) on Windows 10 x64, Ubuntu 18.04 and macOS 11.2.

Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte

Fix baked on nightly for a week, let's take it in 89 beta 10, thanks.

Attachment #9218991 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed on Firefox 89 Beta 10 on Windows 10 x64, Ubuntu 18.04 and macOS 11.3.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: