Wrong highlighted text on search in PDF
Categories
(Firefox :: PDF Viewer, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | + | verified |
firefox90 | --- | verified |
People
(Reporter: bdahl, Assigned: bdahl)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Assignee | ||
Comment 1•4 years ago
|
||
[Tracking Requested - why for this release]:
Visible regression for the PDF viewer.
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1704661
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte
Beta/Release Uplift Approval Request
- User impact if declined: When using "highlight all" in the find bar, not all the text will be highlighted in the correct position.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: https://github.com/mozilla/pdf.js/issues/13292#issue-866739981
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small CSS change.
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
AIUI this was fixed in 90 by bug 1708241?
Comment 6•4 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #5)
AIUI this was fixed in 90 by bug 1708241?
Correct!
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Reproduced the issue on Firefox 89 Beta 5.
Verified fixed on latest Nightly 90.0a1 (buildID: 20210505215208) on Windows 10 x64, Ubuntu 18.04 and macOS 11.2.
Comment 8•4 years ago
|
||
Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte
Fix baked on nightly for a week, let's take it in 89 beta 10, thanks.
Comment 9•4 years ago
|
||
bugherder uplift |
Comment 10•4 years ago
|
||
Verified fixed on Firefox 89 Beta 10 on Windows 10 x64, Ubuntu 18.04 and macOS 11.3.
Updated•4 years ago
|
Description
•