Inconsistent icon colours in search results
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
People
(Reporter: amylee, Assigned: bugzilla)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-address-bar] [proton-uplift])
Attachments
(4 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Light Theme Icons
Light theme icons should all be #5B5B66
Dark theme icons should all be #FBFBFE
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Comment 2•3 years ago
|
||
|
|
Reporter | |
Comment 3•3 years ago
|
||
Comment on attachment 9219327 [details]
Pinned icons
Pinned icons are in the wrong colour
Light theme icons should all be #5B5B66
Dark theme icons should all be #FBFBFE
|
|
Reporter | |
Comment 4•3 years ago
|
||
Comment on attachment 9219326 [details]
Dark theme
Light theme icons should all be #5B5B66
Dark theme icons should all be #FBFBFE
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 5•3 years ago
|
||
Comment on attachment 9219326 [details]
Dark theme
Dark theme icons should all be #FBFBFE
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 6•3 years ago
|
||
There's a ridealong change here to fix up some rules around the local one-offs. There's a rule to make the bookmark button when selected. I made that fill use --urlbar-icon-fill-opacity and also removed related rules for the tabs one-offs. Those were holdovers from when the tabs one-off was green.
|
|
Assignee | |
Comment 7•3 years ago
|
||
The second-and-third-to-last results in Amy's screenshots have a black icon. That's because they're synced tabs results. That's a separate issue, filed at bug 1708757.
|
|
Assignee | |
Comment 8•3 years ago
|
||
Comment on attachment 9219556 [details]
Bug 1708530 - Use --urlbar-icon-fill-opacity everywhere in the Urlbar. r?mak!
Beta/Release Uplift Approval Request
- User impact if declined: Proton color inconsistency
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Verify that default Urlbar icons don't change color when rows are mouse hovered or keyboard selected. They should be the same color as the icons in the Urlbar itself (search glass, bookmarks star). Default icons include:
- Globe icon. This is shown when we don't have a favicon for a site. The easiest way to trigger it is to start typing a website that isn't in history e.g.
https://fakesite - Search glass icon. Shown on search suggestions.
- History clock. Shown on historical search suggestions. Search for something in the Urlbar and press enter. Then, start typing the same search term in the Urlbar.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small CSS change. Only changes some icon opacities.
- String changes made/needed:
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
|
||
Comment 11•3 years ago
|
||
Comment on attachment 9219556 [details]
Bug 1708530 - Use --urlbar-icon-fill-opacity everywhere in the Urlbar. r?mak!
Low risk, approved for 89 beta 8, thanks.
|
|
||
Comment 12•3 years ago
|
||
| bugherder uplift | ||
|
||
Comment 13•3 years ago
|
||
I can no longer reproduce this issue.
I verified using Fx 90.0a1 (2021-05-05) and Fx 89.0b8 on macOS 10.13.6, Windows 10 x64 and Ubuntu 20.04 LTS.
Description
•