Proton: Search mode close "X" is bigger than design
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
People
(Reporter: muirpablo, Assigned: bugzilla)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-address-bar] [priority:2b] [proton-uplift])
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
(deleted),
image/jpeg
|
Details |
image.png
Affected versions
89.0b5 beta
90.0a1 nightly
Affected platforms
Ubuntu 20 64bit , win10 64bit, MacOS 10.14
Preconditions
Proton ON (by default on nightly and beta)
Steps to reproduce
-open new tab
-click on a one off , example.. duckduckgo
-check the "X" on search mode
Actual result
The X is bigger than figma design
Expected result
the X (close) should be smaller.
Hi romain, could you please set a priority for bug?
thanks!
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
[Tracking Requested - why for this release]:
Proton sizing issue. Two-line CSS fix.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Proton style issue; an element in the address bar will be noticeably too big.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Three-line CSS fix; well-understood; tightly scoped.
- String changes made/needed:
|
|
||
Updated•3 years ago
|
Harry , i checked nightly 90.0a1 on Mac 10.14, ubuntu 20 and Mac0S 10.14 now the x is smaller.
but first i thought the x was too high but it ended up being the letters being too low.
do you want me to log a new bug for this? (screenshot attached when checking on windows10)
|
||
Comment 10•3 years ago
|
||
there's already a bug for the text being low, see Bug 1705723
|
|
||
Comment 11•3 years ago
|
||
Comment on attachment 9219335 [details]
Bug 1708533 - Shrink search mode close button. r?mak,#desktop-theme-reviewers
Low risk, approved for 89 beta 8, thanks.
|
|
||
Comment 12•3 years ago
|
||
| bugherder uplift | ||
|
Reporter | |
Comment 13•3 years ago
|
||
verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8
Description
•