Closed Bug 1708572 Opened 4 years ago Closed 4 years ago

Add content to about:addressbook

Categories

(Thunderbird :: Address Book, enhancement)

Product:
Thunderbird
Component:
Address Book
Type:
enhancement

Tracking

(thunderbird_esr78 unaffected)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1708572 - Extract CSS for in-content dialogs into a new file. r?mkmelin
(deleted), text/x-phabricator-request
Details
Bug 1708572 - Create a layout skeleton for about:addressbook. r?mkmelin
(deleted), text/x-phabricator-request
Details
Bug 1708572 - Add the list of address books to about:addressbook. r?mkmelin
(deleted), text/x-phabricator-request
Details
Bug 1708572 - Add the list of contacts to about:addressbook. r?mkmelin
(deleted), text/x-phabricator-request
Details
Bug 1708572 - Add contact editing UI to about:addressbook. r?mkmelin
(deleted), text/x-phabricator-request
Details
Bug 1708572 - Add the toolbar to about:addressbook. r?mkmelin
(deleted), text/x-phabricator-request
Details
No description provided.

This CSS is going to be shared by about:preferences and about:addressbook. I'm putting it in a file by itself so it can be included in both places.

This patch creates the basic layout of the page. The various sections will be filled by subsequent patches.

I've done the whole page with a grid layout so that if we choose to rearrange the panes at runtime it can be done without removing and replacing elements.
Doing that causes problems, as demonstrated by the 3-pane mail window.

Also included is the code to open in-content dialogs.

Depends on D113889

This patch includes a fork of abView.js instead of having one ABView run in both address books as originally intended. There were more changes than expected and I decided not to disturb the existing address book.

Depends on D113891

Attachment #9219401 - Attachment description: WIP: Bug 1708572 - Extract CSS for in-content dialogs into a new file. r?mkmelin → Bug 1708572 - Extract CSS for in-content dialogs into a new file. r?mkmelin
Attachment #9219402 - Attachment description: WIP: Bug 1708572 - Create a layout skeleton for about:addressbook. r?mkmelin → Bug 1708572 - Create a layout skeleton for about:addressbook. r?mkmelin
Attachment #9219403 - Attachment description: WIP: Bug 1708572 - Add the list of address books to about:addressbook. r?mkmelin → Bug 1708572 - Add the list of address books to about:addressbook. r?mkmelin
Attachment #9219413 - Attachment description: WIP: Bug 1708572 - Add the list of contacts to about:addressbook. r?mkmelin → Bug 1708572 - Add the list of contacts to about:addressbook. r?mkmelin

Depends on D113897

Keywords: leave-open
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/27a17c3a7e58 Extract CSS for in-content dialogs into a new file. r=mkmelin

Depends on D114314

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/eb364cdeb27c Create a layout skeleton for about:addressbook. r=mkmelin https://hg.mozilla.org/comm-central/rev/15bd0c17969b Add the list of address books to about:addressbook. r=mkmelin https://hg.mozilla.org/comm-central/rev/8b681fa27274 Add the list of contacts to about:addressbook. r=mkmelin https://hg.mozilla.org/comm-central/rev/f8db8d2c72ba Add contact editing UI to about:addressbook. r=mkmelin https://hg.mozilla.org/comm-central/rev/353300081bd3 Add the toolbar to about:addressbook. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-thunderbird_esr78: --- → unaffected
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: