Insufficient contrast on action text on hover in dark mode
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar] [proton-uplift])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
UX noticed that there's not enough contrast between action text and hovered rows in the Urlbar in dark mode. Screenshot attached. They suggested using the title color for the action text on hover, like we do for keyboard-selected rows. The Figma spec has been updated to reflect this.
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]:
Minor a11y issue; Proton regression; very simple CSS fix.
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9219630 [details]
Bug 1708799 - Set action text to title color on mouse hover. r?adw!
Beta/Release Uplift Approval Request
- User impact if declined: Small a11y Proton regression in the address bar. Some text will have insufficient contrast.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: The bug fix will be easier to notice if you do these steps in dark mode.
- Go to https://bugzilla.mozilla.org/ and bookmark it.
- Right click the address bar and select "Add Bugzilla @ Mozilla"
- Close the tab.
- Start typing "bugzilla" until
bugzilla.mozilla.org
is autofilled and the "Search with Bugzilla @ Mozilla" tab-to-search result is displayed as the second result. - Observe that the text "Search with Bugzilla @ Mozilla directly from the address bar" is grey
- Press the down arrow key to select the result. Observe that the text "Search with Bugzilla @ Mozilla directly from the address bar" is now the same colour as other text in the address bar (white in dark mode, black in light mode).
- Use the arrow keys to unselect the result. Now, hover it with the mouse. Observe that the text "Search with Bugzilla @ Mozilla directly from the address bar" is now the same colour as other text in the address bar.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Two-line CSS change. Well understood, narrowly scoped.
- String changes made/needed:
Assignee | ||
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Comment on attachment 9219630 [details]
Bug 1708799 - Set action text to title color on mouse hover. r?adw!
Low risk, approved for 89 beta 8, thanks.
Comment 7•3 years ago
|
||
bugherder uplift |
Comment 8•3 years ago
|
||
I can confirm the figma spec is respected. Following the steps from comment 4 I verified using Fx 90.0a1(2021-05-05) and Fx 89.0b8 on Windows 10 x64, macOS 10.13.6 and Ubuntu 20.04 LTS.
Updated•2 years ago
|
Description
•