Open
Bug 1708802
Opened 4 years ago
Updated 3 years ago
UITour should not iterate through all browser windows for every closed tab
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
NEW
| Performance Impact | low |
People
(Reporter: florian, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf:frontend, perf:responsiveness)
I captured a profile of closing a bit more than 300 tabs, and UITour looping over every browser window for every "message-manager-close" observer notification repesented about 7% of the time: https://share.firefox.dev/3nBspwF
|
||
Updated•4 years ago
|
Whiteboard: [fxperf] → [fxperf:p2]
|
||
Updated•3 years ago
|
Severity: -- → S3
|
||
Comment 1•3 years ago
|
||
If didDestroy works reliably (I recall some actor teardown methods didn't work reliably a few years ago) then it can probably be used in its actor instead: https://searchfox.org/mozilla-central/rev/6deb8b6af57a8b5b6b1bcb143ea498e566475d8d/browser/components/uitour/UITourParent.jsm#9-10
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Performance Impact: ? → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•