Closed Bug 1708878 Opened 4 years ago Closed 2 years ago

(Proton) (regression) zoom controls in customization mode are unproportional

Categories

(Firefox :: Theme, defect, P3)

Firefox 90
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- fix-optional

People

(Reporter: soeren.hentzschel, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-icons])

Attachments

(1 file)

Attached image screenshot (deleted) —

The minus icon of the zoom controls button in the customization mode is much larger than the plus icon. I attached a screenshot that shows the issue.

Firefox 89 Beta is not affected so it seems to be regressed by a very recent change in Nightly.

Blocks: proton-icons
Component: Toolbars and Customization → Theme
Priority: -- → P3

Can we track down what regressed this? If it's proton work I guess there's a chance it was uplifted to 89 since then.

If it's proton work I guess there's a chance it was uplifted to 89 since then.

Yes, Firefox 89 is affected now as well.

QA Whiteboard: [qa-regression-triage]
Regressed by: 1693856

The "+" icon in the customize palette ends up squished due to this rule added to center the icon while in the toolbar:
https://searchfox.org/mozilla-central/source/browser/themes/shared/toolbarbutton-icons.inc.css#352-355 - which effectively reduces the icon width to 9px in this context.

Some background: the proton "+" icon is aligned to a 16x16 grid and as the vertical stroke is 1.25px wide, it cant be completely centered. The icon designer chose to put the vertical stroke (for this and all the proton icons like it) on the 8th pixel/column. In this context, it looks a little better pulled 1px to the left, so the new rule was to apply 7px left/inline-start padding rather than the normal computed 8px.

I think margin-inline-start: -1px might work better and avoid this fallout in the customize palette.

We're unable to reproduce this, it seems to have been fixed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME

Confirmed. Fixed by bug 1760610 according to mozregression.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: