Closed Bug 1709321 Opened 4 years ago Closed 3 years ago

4.59 - 2.41% JS / Explicit Memory + 7 more (Linux, OSX, Windows) regression on Thu April 29 2021

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox88 unaffected, firefox89 unaffected, firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- fixed

People

(Reporter: aesanu, Assigned: whimboo)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a awsy performance regression from push d14b6e7042992fc00d7a8a9ec9eb117b01083c48. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
5% JS linux1804-64-shippable-qr 90,142,611.05 -> 94,276,292.85
4% JS macosx1015-64-shippable 94,504,314.92 -> 98,526,230.56
4% JS windows10-64-shippable-qr 92,042,008.87 -> 95,889,542.99
4% JS linux1804-64-shippable 91,279,992.23 -> 94,935,851.99
4% JS macosx1015-64-shippable-qr 92,895,212.40 -> 96,550,558.04
4% JS windows10-64-shippable-qr 92,071,902.00 -> 95,651,567.80
4% JS windows10-64-shippable 92,299,096.72 -> 95,684,776.81
2% Explicit Memory windows10-64-shippable-qr 357,149,142.38 -> 366,037,178.53
2% Explicit Memory windows10-64-shippable tp6 432,198,384.69 -> 442,611,582.76

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(hskupin)
status-firefox90: --- → affected

Set release status flags based on info from the regressing bug 1686741

status-firefox88: --- → unaffected
status-firefox89: --- → unaffected
status-firefox-esr78: --- → unaffected

This might be related to bug 1708191. Maybe the new content modal makes it even worse.

Mike, could this maybe also related to the leak that you noticed on bug 1686743 comment 14?

Depends on: 1708191
Flags: needinfo?(hskupin) → needinfo?(mconley)

Possibly? One of the things I had noticed was that with the new modal system, we often have these preloaded dialogs hanging around. That might account for the lost memory.

Flags: needinfo?(mconley)

As https://treeherder.mozilla.org/perfherder/graphs?series=try,2203896,1,4&selected=2203896,1356774189 shows the leak comes from Firefox itself. See bug 1708191 comment 6 for details.

It means that this bug will be fixed at the same time when bug 1708191 is no longer around.

Fixed by my patch on bug 1708191.

Assignee: nobody → hskupin
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.