[Proton] [reddit.com] The overscroll animation is not displayed on pages with reddit topics opened
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | unaffected |
| firefox89 | --- | affected |
| firefox90 | --- | affected |
People
(Reporter: tbabos, Unassigned)
References
(Blocks 2 open bugs, )
Details
(Whiteboard: [mac:ux] )
Affected Versions:
Nightly 90.0a1
Beta 89.0b7
Affected Platforms:
MacOS
Steps to reproduce:
- Go to reddit.com
- Click on any topis, such as: https://www.reddit.com/r/formula1/comments/n59sn5/mercedesamg_petronas_f1_team_hes_back_rgrosjean/
- Swipe up multiple times
Expected Results:
The over scroll animation should be correctly displayed above the fixed header.
Actual Results:
The overscroll animation is not displayed for reddit posts.
Recording: https://drive.google.com/file/d/17ZBgRcNgYTD_0ezmenLq6aAaD0y3O3CY/view?usp=sharing
Notes:
Scrolling down and fast swipe up will display the overscroll animation.
|
Reporter | |
Comment 1•3 years ago
|
||
Similar behavior can be observed on sketchfab: https://sketchfab.com/search?q=text&sort_by=-relevance&type=models
|
||
Comment 2•3 years ago
|
||
There appear to be two different issues here:
- Whether the fixed header is included in the overscroll animation. It looks to me like Reddit can serve two different page structures: one where the <html> is scrollable, and one where a <div> containing the contents under the header is scrollable. You can tell the difference from the scollbar: if the scrollbar overlaps the header when scrolled to the top, it's the <html>, but if the scrollbar starts underneath the header, it's the <div>. The fixed header is included in the overscroll animation only when the <html> is scrollable. While it's strange for Reddit to be switching the page structure like this, the behaviour is expected from the browser's point of view.
- Sometimes, overscroll does not work at all if you start scrolled to the top (but it does if you scroll down and back up). This seems to only happen in the <div> case. This one requires further investigation.
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Comment 3•3 years ago
|
||
Issue (2) from comment 2 is a more general issue (affecting all subframes) which we are tracking in bug 1709723.
Issue (1) is expected behaviour as explained.
==> I'm going to dupe this over to bug 1709723.
|
|
Reporter | |
Comment 4•3 years ago
|
||
Looking at this fix on Nightly for Issue (2) since Bug 1709723 is fixed.
We do overscroll now, but unfortunately on some Reddit posts, the black header will be duplicated in the overscroll animation. Please see attached recording: https://drive.google.com/file/d/1diwEgyJRD7HK0vvPJ1AAVOhDnCJmLJQl/view?usp=sharing
Steps to reproduce:
- Go to https://www.reddit.com/r/Competitiveoverwatch/comments/n6h069/overwatch_league_fans/
- If the issue is not reproducible there open a different reddit post from below and it should be reproducible on that one
Let me know if I should submit a new bug or not. Thanks!
|
|
||
Comment 5•3 years ago
|
||
(In reply to Timea Cernea [:tbabos] from comment #4)
Let me know if I should submit a new bug or not. Thanks!
Please do -- thanks!
|
|
||
Comment 6•3 years ago
|
||
(In reply to Timea Cernea [:tbabos] from comment #4)
on some Reddit posts, the black header will be duplicated in the overscroll animation. Please see attached recording: https://drive.google.com/file/d/1diwEgyJRD7HK0vvPJ1AAVOhDnCJmLJQl/view?usp=sharing
Steps to reproduce:
- Go to https://www.reddit.com/r/Competitiveoverwatch/comments/n6h069/overwatch_league_fans/
- If the issue is not reproducible there open a different reddit post from below and it should be reproducible on that one
I did look briefly into this. Some more specific STR to trigger this:
- Visit a Reddit thread, such as the mentioned link. Let's call this thread (1).
- Scroll down to the "More posts from the <subreddit name> community" section of the page, and click on another thread there. Let's call this thread (2).
When you do this, Reddit serves a page where the black header still shows the title of thread (1), but the contents underneath are now thread (2). Moreover, the header for thread (1) is outside the scrollable element. A black header with the title of thread (2) is also present, but underneath the thread (1) header, and inside the scrollable element.
When you then overscroll the scrollable element, the header for thread (2) that was previously hidden "peeks out" from under the thread (1) header.
This is a strange thing for Reddit to be doing, but our behaviour is consistent with the page structure.
|
|
Reporter | |
Comment 7•3 years ago
|
||
Sorry for not logging the bug yet, was out of time. Given your investigation on this and the outcome should I still log a bug maybe for tracking purposes at least?
|
|
||
Comment 8•3 years ago
|
||
(In reply to Timea Cernea [:tbabos] from comment #7)
Given your investigation on this and the outcome should I still log a bug maybe for tracking purposes at least?
Sure, we can have a bug on file so we have a place to point users if they report this issue, and to discuss possible workarounds if desirable. Thanks!
Description
•