Closed Bug 1709720 Opened 4 years ago Closed 3 years ago

Refactor browser_aboutwelcome_multistage tests

Categories

(Firefox :: Messaging System, enhancement, P2)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Iteration:
92.1 - Jul 12 - Jul 25
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: pdahiya, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ujet-tech-debt])

Attachments

(1 file)

Bug 1709720 - Refactor multistage about_welcome tests and remove unused code
(deleted), text/x-phabricator-request
Details

https://searchfox.org/mozilla-central/source/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js

Mochitest above has grown huge > 1000 lines increasing complexity and encompasses UI tests covering
a) Default Multistage Welcome
b) MultiStageWelcome using Experiment API
c) Multistage welcome using proton design

Scope of this bug is to refactor mochitest into sub files, moving common util functions if needed in head.js and remove any redundant tests such as browser_aboutwelcome_simplified.js

See https://phabricator.services.mozilla.com/D114268#inline-635531 for useful Experiment API util functions such as enrollWithFeatureConfig

Summary: Refactor browser_aboutwelcome_multistage mochitests → Refactor browser_aboutwelcome_multistage tests

It would be nice if we could add a simple a11y test for Proton as part of this refactor: We just need to check that the main-content H1 is the activeElement when about:welcome loads (Eitan suggested checking activeElement as done in browser_customize_menu_content.js).

Priority: -- → P2
Whiteboard: [ujet-tech-debt]
Depends on: 1713896
Assignee: nobody → emcminn
Attachment #9231628 - Attachment description: WIP: Bug 1709720 - Refactor multistage about_welcome tests and remove unused code → Bug 1709720 - Refactor multistage about_welcome tests and remove unused code
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37541c177242 Refactor multistage about_welcome tests and remove unused code r=pdahiya

https://hg.mozilla.org/mozilla-central/rev/37541c177242

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Iteration: --- → 92.1 - Jul 12 - Jul 25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: