Closed Bug 1709851 Opened 4 years ago Closed 3 years ago

Update GMP fallback downloader for Widevine CDM 4.10.2209.1

Categories

(Core :: Audio/Video: Playback, task, P1)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox-esr78 --- fixed
firefox88 --- wontfix
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: bryce, Assigned: bryce)

References

Details

Attachments

(2 files)

Now that we're serving the new CDM via balrog and issues have been ironed out, we should update the fallback downloader.

As part of this update I plan to also switch the formatting of the json file in tree to match that used by balrog[0]. Right now the json file in tree[1] uses an equivalent set of attributes, but with a different ordering. Using the same ordering will make it easier to diff the files without doing something like parsing the json.

[0] https://aus-api.mozilla.org/api/v1/releases/Widevine-4.10.2209.1
[1] https://searchfox.org/mozilla-central/rev/3151f97de27730793c2e298716df760999423f26/toolkit/content/gmp-sources/widevinecdm.json

Script I used to generate the json file so my working can be checked. Based on scripts used previously but with the lines move around and the new ARM mac case added.

Note, this leaves out the "product": "Widevine", line that balrog has in its json, but the generated json should be the same aside from that.

Attachment #9220662 - Attachment description: Script used to generate the json file → Python script used to generate the json file. Requires requests lib to run.

Comment on attachment 9220662 [details]
Python script used to generate the json file. Requires requests lib to run.

Mark the script as text so it's nicer to read on bugzilla.

Attachment #9220662 - Attachment mime type: application/octet-stream → text/plain

Update the GMP fallback downloader for Widevine to reference the 4.10.2209.1
CDM. This keeps the fallback URLs in step with Balrog.

Add the aarch64/arm64 entry for the new Apple Silicone CDM to the fallback.

Reorder the json file so it matches the ordering used by balrog so it's easier
to eyeball and diff the files.

Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58e693a6bde5 Update fallback GMP downloader for Widevine 4.10.2209.1. r=mjf
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9220667 [details]
Bug 1709851 - Update fallback GMP downloader for Widevine 4.10.2209.1. r?rhelmer

Beta/Release Uplift Approval Request

  • User impact if declined: Users will get an outdated version of the Widevine CDM if an old fallback URL is used (this will happen if they cannot connect to the update server and don't have a CDM installed). Such versions of Widevine may fail to play content due to deactivation.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Well understood change that we've made before and the contents of the json file can be verified against the almost identical json served from balrog.
  • String changes made/needed: None
Attachment #9220667 - Flags: approval-mozilla-beta?

Comment on attachment 9220667 [details]
Bug 1709851 - Update fallback GMP downloader for Widevine 4.10.2209.1. r?rhelmer

We are no longer in beta. Approved before building our release candidate in a couple of hours.

Attachment #9220667 - Flags: approval-mozilla-release+
Attachment #9220667 - Flags: approval-mozilla-beta?
Attachment #9220667 - Flags: approval-mozilla-beta-

Comment on attachment 9220667 [details]
Bug 1709851 - Update fallback GMP downloader for Widevine 4.10.2209.1. r?rhelmer

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Impacts premium (DRM protected) video.
  • User impact if declined: Users will get an outdated version of the Widevine CDM if an old fallback URL is used (this will happen if they cannot connect to the update server and don't have a CDM installed). Such versions of Widevine may fail to play content due to deactivation.
  • Fix Landed on Version: 90
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Well understood change that we've made before and the contents of the json file can be verified against the almost identical json served from balrog.
  • String or UUID changes made by this patch: None.
Attachment #9220667 - Flags: approval-mozilla-esr78?

Comment on attachment 9220667 [details]
Bug 1709851 - Update fallback GMP downloader for Widevine 4.10.2209.1. r?rhelmer

Approved for ESR78. This missed the 78.11.0esr RC1 build but will ship in whatever release comes next off that branch.

Attachment #9220667 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+

FYI, we ended up needing a 78.11.0esr build2 which included the commit from comment 12.

I see a 32 bit Windows version, but not a 32 bit Linux version for 4.10.2209.1
https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.2209.1-win-ia32.zip

Is 32 bit Linux no longer supported by Widevine CDM 4.10.2209.1 ?

(In reply to dickvl from comment #14)

I see a 32 bit Windows version, but not a 32 bit Linux version for 4.10.2209.1
https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.2209.1-win-ia32.zip

Is 32 bit Linux no longer supported by Widevine CDM 4.10.2209.1 ?

Yes, that is correct.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: