Closed
Bug 171004
Opened 22 years ago
Closed 22 years ago
Add support for shared menus to Chimera
Categories
(Camino Graveyard :: Toolbars & Menus, enhancement)
Tracking
(Not tracked)
VERIFIED
FIXED
Chimera0.6
People
(Reporter: sdagley, Assigned: sdagley)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
With Alco Blom's help this is looking very possible (read I have a build with it
but it's not ready for prime time). Logging a bug so it actually shows up on radar.
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Chimera0.6
Comment 1•22 years ago
|
||
Add similar support to the Mc OS builds of Mozilla. This should _not_ be Chimera
specific. It will be wanted in any Mac OS port of mozilla including Netscape and also
Mozilla itself.
See also bug 56589 (Mozilla equivalent). Reassigning to Toolbars & Menus.
Assignee: sdagley → brade
Component: General → Toolbars & Menus
QA Contact: winnie → sairuh
Comment 3•22 years ago
|
||
I think sdagley is working on this bug; if not, you can reassign back to me
-->sdagley
Assignee: brade → sdagley
Assignee | ||
Comment 4•22 years ago
|
||
Yep, I am working on it. Looks like Greg did the old reassign to default owner
when he moved it to Toolbars & Menus
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•22 years ago
|
||
This is going to require Alco's shared menu framework at:
ftp://ftp.url-manager.com/pub/SharedMenusCocoa.sit.bin
Assignee | ||
Comment 6•22 years ago
|
||
With the SharedMenusCocoa.framework from
<ftp://ftp.url-manager.com/pub/SharedMenusCocoa.sit.bin> installed in
/Library/Frameworks this patch will enable shared menu support in Chimera. Or
so I think as it seems to have FSRefs as references to the files and those
aren't portable. Not that I'm sure as this is my first patch to the Chimera PB
file. Posting so others can try and see if it actually builds on another
machine.
Assignee | ||
Comment 7•22 years ago
|
||
Expanding my potential testing base
Assignee | ||
Comment 8•22 years ago
|
||
Forgot to use -U 4 to include context for the previous patch
Attachment #103551 -
Attachment is obsolete: true
Comment 9•22 years ago
|
||
+ // Initialize shared menu support
+ mSharedMenusObj = [SharedMenusObj alloc];
+ if (mSharedMenusObj)
+ [mSharedMenusObj init];
The usual way is
mSharedMenusObj = [[SharedMenusObj alloc] init];
+ // Terminate shared menus
+ if (mSharedMenusObj) {
+ [mSharedMenusObj dealloc];
+ mSharedMenusObj = nil;
+ }
This should be [[mSharedMenusObj release];
Assignee | ||
Comment 10•22 years ago
|
||
Revised patch per sfraser's suggestions and Alco has posted a new (usable)
version of the framework although it still has duplicate versions. He should
rectify that on Wednesday (10/24). Can someone verify and land this please?
Assignee | ||
Updated•22 years ago
|
Attachment #103553 -
Attachment is obsolete: true
Comment 11•22 years ago
|
||
With the release of Url Manager Pro 3.0.1 late last month, it would be really
nice to see this patch landed.
Assignee | ||
Comment 12•22 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•