Closed Bug 171004 Opened 22 years ago Closed 22 years ago

Add support for shared menus to Chimera

Categories

(Camino Graveyard :: Toolbars & Menus, enhancement)

PowerPC
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Chimera0.6

People

(Reporter: sdagley, Assigned: sdagley)

Details

Attachments

(1 file, 2 obsolete files)

With Alco Blom's help this is looking very possible (read I have a build with it but it's not ready for prime time). Logging a bug so it actually shows up on radar.
Target Milestone: --- → Chimera0.6
Add similar support to the Mc OS builds of Mozilla. This should _not_ be Chimera specific. It will be wanted in any Mac OS port of mozilla including Netscape and also Mozilla itself.
See also bug 56589 (Mozilla equivalent). Reassigning to Toolbars & Menus.
Assignee: sdagley → brade
Component: General → Toolbars & Menus
QA Contact: winnie → sairuh
I think sdagley is working on this bug; if not, you can reassign back to me -->sdagley
Assignee: brade → sdagley
Yep, I am working on it. Looks like Greg did the old reassign to default owner when he moved it to Toolbars & Menus
Status: NEW → ASSIGNED
This is going to require Alco's shared menu framework at: ftp://ftp.url-manager.com/pub/SharedMenusCocoa.sit.bin
With the SharedMenusCocoa.framework from <ftp://ftp.url-manager.com/pub/SharedMenusCocoa.sit.bin> installed in /Library/Frameworks this patch will enable shared menu support in Chimera. Or so I think as it seems to have FSRefs as references to the files and those aren't portable. Not that I'm sure as this is my first patch to the Chimera PB file. Posting so others can try and see if it actually builds on another machine.
Expanding my potential testing base
Attached patch as above but w/-U 4 (obsolete) (deleted) — Splinter Review
Forgot to use -U 4 to include context for the previous patch
Attachment #103551 - Attachment is obsolete: true
+ // Initialize shared menu support + mSharedMenusObj = [SharedMenusObj alloc]; + if (mSharedMenusObj) + [mSharedMenusObj init]; The usual way is mSharedMenusObj = [[SharedMenusObj alloc] init]; + // Terminate shared menus + if (mSharedMenusObj) { + [mSharedMenusObj dealloc]; + mSharedMenusObj = nil; + } This should be [[mSharedMenusObj release];
Attached patch per sfraser's suggestions (deleted) — Splinter Review
Revised patch per sfraser's suggestions and Alco has posted a new (usable) version of the framework although it still has duplicate versions. He should rectify that on Wednesday (10/24). Can someone verify and land this please?
Attachment #103553 - Attachment is obsolete: true
With the release of Url Manager Pro 3.0.1 late last month, it would be really nice to see this patch landed.
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
vrfy'd fixed on 10.2.2 with 2002.11.14.04.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: