Closed Bug 1710164 Opened 4 years ago Closed 3 years ago

White-on-white text on in-content pages when using macOS Dark Mode + High Contrast Mode, if widget.macos.respect-system-appearance is enabled

Categories

(Core :: Widget: Cocoa, defect, P2)

All
macOS
defect

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: mstange, Assigned: bugzilla)

References

Details

(Whiteboard: [proton-cleanup])

Attachments

(1 file)

STR:

  1. Set widget.macos.respect-system-appearance to true.
  2. Enable macOS dark mode.
  3. Enable "Increase contrast" in Accessibility.
  4. Go to about:profiles.

Expected results:
White text and dark background.

Actual results:
White text and white background.

When "Increase contrast" is enabled, Firefox uses -moz-Dialog for the in-content page background. At the moment, -moz-Dialog resolves to rgba(255, 255, 255, 0.098) in dark mode. This is a very low-opacity white color, rather than an opaque dark color. It seems to be intended to be used on top of a dark backdrop.

I'm getting this on other in-content pages, like about:preferences, about:config, and about:sessionrestore.

Severity: -- → S2
Priority: -- → P2
Summary: White-on-white text on about:profiles when using macOS Dark Mode + High Contrast Mode, if widget.macos.respect-system-appearance is enabled → White-on-white text on in-content pages when using macOS Dark Mode + High Contrast Mode, if widget.macos.respect-system-appearance is enabled
Whiteboard: [proton-cleanup]
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Depends on: 1715145
No longer depends on: 1715145
Blocks: 1715619
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56aa4be0522c Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ec370f03e4d Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: needinfo?(htwyford)

Hello,

Managed to reproduce this issue on 90.0a(120210507095221), with macOS 11 device.

Confirming this issue as verified fixed on 90.0b8(20210615190254) and 91.0a1(20210617095423) using macOS 11 and macOS 10.15.7

Status: RESOLVED → VERIFIED

Are sure this is fixed on Firefox 90? The code fix only landed on Firefox 91 and wasn't uplifted. When you tested Firefox 90 did you set widget.macos.respect-system-appearance to true?

Flags: needinfo?(vlad.lucaci)

Hello Mathew.

Yes I have set widget.macos.respect-system-appearance to true. and yes, this issue was only verified in 91.0a1(20210617095423).

Flags: needinfo?(vlad.lucaci)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: