Closed Bug 1710325 Opened 4 years ago Closed 3 years ago

Software WebRender causes Proton tabs to render incorrectly

Categories

(Core :: Graphics: WebRender, defect)

Firefox 89
Desktop
All
defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: sam, Assigned: lsalzman)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image Left is SW-WR, right is WR (deleted) —

The right side of Proton tabs render differently in Software WebRender when compared to both Hardware WebRender and Basic. The behavior is consistent across hardware and OS (example screenshots from macOS, but the difference is the same in Windows 10 on another machine).

Mozregression says this was caused by bug 1702329, which was a CSS change. Since this only looks bad in SW-WR, I am filing against that, but there is a chance this could be theme-related.

Severity: -- → S3

We accidentally were clamping the horizontal stage of the separable blur some
number of samples too early before the end of the row, rather than at the end
of the row.

Assignee: nobody → lsalzman
Attachment #9222313 - Attachment description: Bug 1710325 - Fix offset clamping in SWGL horizontal blur. r?jrmuizel → Bug 1710325 - Fix offset clamping in SWGL blur fast-path. r?jrmuizel
Version: Firefox 90 → Firefox 89
Regressed by: 1652266
Has Regression Range: --- → yes
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1b461b1982e Fix offset clamping in SWGL blur fast-path. r=jrmuizel
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9222313 [details]
Bug 1710325 - Fix offset clamping in SWGL blur fast-path. r?jrmuizel

Beta/Release Uplift Approval Request

  • User impact if declined: Visual artifacts in some Proton UI chrome for Software WebRender users (which is being rolled out in 89).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The impact is mostly confined to SW-WR users, and it is mostly a small cosmetic change.
  • String changes made/needed:
Attachment #9222313 - Flags: approval-mozilla-beta?

Lee, you patch does not graft to beta cleanly as it changes tests that landed in bug 1706716 in 90, do you want to provide an updated patch for beta? Thanks

Flags: needinfo?(lsalzman)

I've rebased this version of the patch for 89. It will apply now.

Flags: needinfo?(lsalzman)

Comment on attachment 9222642 [details] [diff] [review]
Bug 1710325 - Fix offset clamping in SWGL blur fast-path (89). r=jrmuizel

Approved for 89 beta 15, thanks.

Attachment #9222642 - Flags: approval-mozilla-beta+
Attachment #9222313 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: