Autofill address/credit card dialogs are unnecessarily scrollable
Categories
(Firefox :: Settings UI, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | unaffected |
| firefox90 | --- | verified |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-modals])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The 6px padding on :root added in bug 1705330 is causing these dialogs to scroll by 12px vertically.
I don't really understand why, off-hand - perhaps the scrollHeight for the document isn't taking the padding into account, and we should be adding the padding to body instead, for the HTML dialog case? I also noticed that bug 1684530 solved the same problem as bug 1705330 but only for the autofill dialogs.
These kinds of bugs would stand a better chance of not being introduced if these features were default-enabled...
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
I messed up the initial tracking flags here, this doesn't affect 89 anyways, because the regressing bug, bug 1705330, wasn't uplifted.
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
I have reproduced this on an affected Nightly build 90.0a1 (2021-05-10)
Confirming this issue as verified fixed on Win 10x64, Ubuntu 20.04 and macOS 10.15, using Firefox 90.0b5 (2021-06-08).
Thanks!
|
||
Updated•3 years ago
|
Description
•