Closed
Bug 1710676
Opened 3 years ago
Closed 3 years ago
changes for libwebrtc update in dom/media/systemservices/MediaUtils.h used an anonymous namespace
Categories
(Core :: WebRTC: Audio/Video, task, P2)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: mjf, Assigned: pehrsons)
References
Details
Attachments
(2 files)
Base toolchain builds (specifically build-linux64-base-toolchains/opt) give this error:
/builds/worker/workspace/obj-build/dist/include/mozilla/media/MediaUtils.h:192:7: error: 'mozilla::media::ShutdownBlockingTicket' has a field 'mozilla::media::ShutdownBlockingTicket::mTicket' whose type uses the anonymous namespace [-Werror=subobject-linkage]
To make the base toolchain builds happy, I changed the anonymous namespace to "anon_media_utils" but this should be fixed in a less hacky way.
|
||
Comment 1•3 years ago
|
||
This is something we have to do along with bug 1654112, right?
Severity: -- → S2
Priority: -- → P2
|
Reporter | |
Comment 2•3 years ago
|
||
Sort of. This is something that was hacked around to fix build issues in 1654112, but should be fixed eventually in a better way. I'm not sure exactly why Andreas did this the way he did.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → apehrson
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/52d8fdc84d72 Make ShutdownBlockingTicket an interface and hide the impl behind a factory method. r=mjf https://hg.mozilla.org/integration/autoland/rev/b83f00e145cf Fix static-analysis warnings. r=mjf
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52d8fdc84d72
https://hg.mozilla.org/mozilla-central/rev/b83f00e145cf
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•