Closed
Bug 1710848
Opened 4 years ago
Closed 4 years ago
Address row with multiple rows of recipient pills still has double focus border at the top
Categories
(Thunderbird :: Theme, defect, P3)
Tracking
(thunderbird_esr78 unaffected, thunderbird89 affected)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird89 | --- | affected |
People
(Reporter: thomas8, Assigned: Paenglab)
References
Details
Attachments
(3 files)
Screenshot with double-focus border at the top (with multiple rows of recipients)
+++ This bug was initially created as a clone of Bug #1703988 +++
Address row with multiple rows of recipients still has double focus border (at the top)
|
Reporter | |
Comment 1•4 years ago
|
||
First screenshot looks not clear, let's try again
|
|
Reporter | |
Updated•4 years ago
|
Summary: Address row with multiple rows of recipients still has double focus border → Address row with multiple rows of recipients still has double focus border at the top
|
|
Reporter | |
Updated•4 years ago
|
Summary: Address row with multiple rows of recipients still has double focus border at the top → Address row with multiple rows of recipient pills still has double focus border at the top
|
Assignee | |
Comment 2•4 years ago
|
||
This seems to be only a Windows issue.
I'm using now for the margin-bottom 1em instead of 12px to fit also with bigger font sizes.
Attachment #9221759 -
Flags: review?(alessandro)
|
||
Updated•4 years ago
|
Status: NEW → ASSIGNED
status-thunderbird89:
--- → affected
OS: Unspecified → Windows
Hardware: Unspecified → Desktop
|
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9221759 [details] [diff] [review]
1710848-pill-indicator.patch
Review of attachment 9221759 [details] [diff] [review]:
-----------------------------------------------------------------
Wouldn't be better to have a the padding-top: -2px to the shared style and have a unique variation in the windows style?
Instead of having the same variation repeated for both Linux and macOS?
Attachment #9221759 -
Flags: review?(alessandro)
|
|
Assignee | |
Comment 4•4 years ago
|
||
Like it is now, the property is only added one time (or not for Windows). With your proposal it is applied and then removed again. We normally don't do this.
|
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9221759 [details] [diff] [review]
1710848-pill-indicator.patch
Review of attachment 9221759 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good.
Attachment #9221759 -
Flags: review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → 90 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/89ad7fa6f4dc
Better aligning of the pill-indicator. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•