Closed Bug 1710910 Opened 3 years ago Closed 2 years ago

Reduce the size of the close button on infobars and use the correct smaller close icon for tabs

Categories

(Firefox :: Theme, defect, P2)

defect
Points:
1

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: jaws, Assigned: sfoster)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [proton-icons] [proton-infobars] [proton-tabs-bar] [proton-cleanups] [priority:2b][fidefe-Quality-Foundation])

Attachments

(1 file)

Katie pointed out to me that the close icon for infobars should be reduced in size to use close-12.svg, and the tab's close icon which is already 12px by 12px isn't using close-12.svg, which has better pixel alignment at that size.

While working on this we noticed that the tab close button isn't using the --toolbarbutton-icon-fill color.

Priority: -- → P2
Whiteboard: [proton-icons] [proton-infobars] [proton-tabs-bar] → [proton-icons] [proton-infobars] [proton-tabs-bar] [priority:2b]
Whiteboard: [proton-icons] [proton-infobars] [proton-tabs-bar] [priority:2b] → [proton-icons] [proton-infobars] [proton-tabs-bar] [proton-cleanups] [priority:2b]
Points: --- → 1

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:jaws, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jaws)
Flags: needinfo?(dao+bmo)
Flags: needinfo?(soeren.hentzschel)

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #3)

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:jaws, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

S4 seems right for this.

Flags: needinfo?(jaws)
Whiteboard: [proton-icons] [proton-infobars] [proton-tabs-bar] [proton-cleanups] [priority:2b] → [proton-icons] [proton-infobars] [proton-tabs-bar] [proton-cleanups] [priority:2b][fidefe-Quality-Foundation]
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a56f7bf6fb9b Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. r=sfoster,mstriemer,desktop-theme-reviewers,dao
Flags: needinfo?(weinjared+bmo)
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17805375f92a Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. r=sfoster,mstriemer,desktop-theme-reviewers,dao

Backed out by mistake.
Relanded the changes, sorry

Flags: needinfo?(weinjared+bmo)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1818233
Assignee: weinjared+bmo → prathikshaprasadsuman
Status: RESOLVED → REOPENED
Flags: needinfo?(prathikshaprasadsuman)
Resolution: FIXED → ---
Target Milestone: 112 Branch → ---

I'll look into this. Thanks for flagging!

Flags: needinfo?(prathikshaprasadsuman)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:prathiksha, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(mstriemer)
Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(mstriemer)
Flags: needinfo?(sfoster)

I'll see if I can gets this re-landed.

Assignee: prathikshaprasadsuman → sfoster
Flags: needinfo?(sfoster)
Attachment #9221659 - Attachment description: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. → WIP: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs.
Attachment #9221659 - Attachment description: WIP: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. → WIP: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon
Attachment #9221659 - Attachment description: WIP: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon → Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon
Attachment #9221659 - Attachment description: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon → Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5b2f3b5a89b Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs r=mstriemer,desktop-theme-reviewers,dao
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: