Closed Bug 1710970 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 28982 - Switch to flat tree traversal for <popup> ancestral element search

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28982 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28982
Details from upstream follow.

b'Mason Freed <masonf@chromium.org>' wrote:

Switch to flat tree traversal for <popup> ancestral element search

Previously, a light-DOM parent traversal was used, however, this was
already questionable, and it breaks the \<selectmenu> use case. So I
think the right thing to do here is a flat tree traversal.

Bug: 1168738
Change-Id: I1008fed2a41d729c7dba79b878ed8f7845d95eb6
Reviewed-on: https://chromium-review.googlesource.com/2893593
WPT-Export-Revision: 4a9742e392e577fb17b0686f3b8a836764f7cdf1

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-shadow-dom.tentative.html
Popups located inside shadow DOM can still be shown: FAIL (Chrome: PASS, Safari: FAIL)
anchor references do not cross shadow boundaries: FAIL (Chrome: PASS, Safari: FAIL)
anchor references use the flat tree not the DOM tree: FAIL (Chrome: FAIL, Safari: FAIL)
The popup stack is preserved across shadow-inclusive ancestors: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2435214076fe [wpt PR 28982] - Switch to flat tree traversal for <popup> ancestral element search, a=testonly https://hg.mozilla.org/integration/autoland/rev/2f31610dea90 [wpt PR 28982] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2435214076fe
https://hg.mozilla.org/mozilla-central/rev/2f31610dea90

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.