Closed Bug 1711895 Opened 3 years ago Closed 3 years ago

Don't release lastExpressionResult ObjectFront from ParentDevToolsInspectorSidebar#close

Categories

(WebExtensions :: Developer Tools, task)

task

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

With Bug 1699493, DevToolsExtensionPageContextParent has a "DevTools" commands instance that gets destroyed when the extension is unloaded.

When the commands are destroyed, it leads to the destruction of the tabDescriptor front, which will release/destroy all the fronts in the Tree.

This makes the call to _updateLastExpressionResult in ParentDevToolsInspectorSidebar#close [1] unnecessary as any object fronts will be released as part of the command destruction.

[1] https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/browser/components/extensions/parent/ext-devtools-panels.js#417-418

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: