Closed
Bug 1712598
Opened 4 years ago
Closed 3 years ago
Let AudioDecoderInputTrack fill silence to the output if we write less frames than expectation
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P3)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Regressed 2 open bugs)
Details
Attachments
(2 files)
Fork from this.
|
Assignee | |
Comment 1•4 years ago
|
||
If there is a gap bewteen the audio that is going to be appended next and the amount of frames that we've appended, then we need to fill silence data in order to keep A/V sync correct.
We did that for the DecodedStream [1] before, but that got removed during the refactoring.
Depends on D115749
|
||
Updated•3 years ago
|
Attachment #9223293 -
Attachment description: Bug 1712598 - fill silence if detecting a gap in audio. → Bug 1712598 - part1 : fill silence if detecting a gap in audio.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D115857
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49489b3d5a3e
part1 : fill silence if detecting a gap in audio. r=padenot
https://hg.mozilla.org/integration/autoland/rev/97a63d63d219
part2 : add a test for A/V sync. r=padenot
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/49489b3d5a3e
https://hg.mozilla.org/mozilla-central/rev/97a63d63d219
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•