Closed Bug 1712671 Opened 3 years ago Closed 3 years ago

Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1773:16 in OnMsgInputClosed

Categories

(Core :: Networking, defect, P1)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 94+ fixed
firefox93 --- wontfix
firefox94 + fixed
firefox95 + fixed

People

(Reporter: intermittent-bug-filer, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Keywords: csectype-race, intermittent-failure, sec-moderate, Whiteboard: [necko-triaged][adv-main94+r][adv-esr91.3+r])

Attachments

(1 file)

Bug 1712671 - Make nsSocketTransport2::m{Input/Output}StreamClosed atomic r=#necko
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr91+
Details

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=340699826&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZHQNS1OiSYKvgMnc0LFb5Q/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZHQNS1OiSYKvgMnc0LFb5Q/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2021-05-25T04:53:49.873Z] 04:53:49     INFO - REFTEST TEST-START | image/test/crashtests/1676172-1.html
[task 2021-05-25T04:53:49.880Z] 04:53:49     INFO - REFTEST INFO | SET PREFERENCE pref(image.animated.decode-on-demand.batch-size,1)
[task 2021-05-25T04:53:49.891Z] 04:53:49     INFO - REFTEST INFO | SET PREFERENCE pref(image.animated.decode-on-demand.threshold-kb,0)
[task 2021-05-25T04:53:49.891Z] 04:53:49     INFO - REFTEST TEST-LOAD | http://localhost:45940/1621918111323/34/1676172-1.html | 421 / 493 (85%)
[task 2021-05-25T04:53:51.183Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:51.363Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:51.579Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:51.716Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:51.814Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:51.983Z] 04:53:51     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.128Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.322Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.462Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.473Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.558Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:52.803Z] 04:53:52     INFO - JavaScript error: resource://specialpowers/AppTestDelegateParent.jsm, line 10: NS_ERROR_NOT_AVAILABLE:
[task 2021-05-25T04:53:53.054Z] 04:53:53     INFO - ==================
[task 2021-05-25T04:53:53.054Z] 04:53:53     INFO - WARNING: ThreadSanitizer: data race (pid=1457)
[task 2021-05-25T04:53:53.054Z] 04:53:53     INFO -   Write of size 1 at 0x7b5c001cac75 by thread T6:
[task 2021-05-25T04:53:53.055Z] 04:53:53     INFO -     #0 OnMsgInputClosed /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1773:16 (libxul.so+0xd84908)
[task 2021-05-25T04:53:53.056Z] 04:53:53     INFO -     #1 mozilla::net::nsSocketTransport::OnInputClosed(nsresult) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.h:406:7 (libxul.so+0xd84908)
[task 2021-05-25T04:53:53.057Z] 04:53:53     INFO -     #2 mozilla::net::nsSocketInputStream::CloseWithStatus(nsresult) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:443:34 (libxul.so+0xd850e9)
[task 2021-05-25T04:53:53.057Z] 04:53:53     INFO -     #3 mozilla::net::nsSocketInputStream::Close() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:306:39 (libxul.so+0xd84093)
[task 2021-05-25T04:53:53.059Z] 04:53:53     INFO -     #4 mozilla::net::nsSocketInputStream::Release() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:301:29 (libxul.so+0xd83f7f)
[task 2021-05-25T04:53:53.059Z] 04:53:53     INFO -     #5 assign_assuming_AddRef /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:377:7 (libxul.so+0xb9bb0c)
[task 2021-05-25T04:53:53.060Z] 04:53:53     INFO -     #6 assign_assuming_AddRef /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:400:20 (libxul.so+0xb9bb0c)
[task 2021-05-25T04:53:53.060Z] 04:53:53     INFO -     #7 operator= /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:696:5 (libxul.so+0xb9bb0c)
[task 2021-05-25T04:53:53.062Z] 04:53:53     INFO -     #8 nsAStreamCopier::Process() /builds/worker/checkouts/gecko/xpcom/io/nsStreamUtils.cpp:346:17 (libxul.so+0xb9bb0c)
[task 2021-05-25T04:53:53.062Z] 04:53:53     INFO -     #9 Run /builds/worker/checkouts/gecko/xpcom/io/nsStreamUtils.cpp:418:5 (libxul.so+0xb98f41)
[task 2021-05-25T04:53:53.062Z] 04:53:53     INFO -     #10 non-virtual thunk to nsAStreamCopier::Run() /builds/worker/checkouts/gecko/xpcom/io/nsStreamUtils.cpp (libxul.so+0xb98f41)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #11 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1153:16 (libxul.so+0xbdc9ff)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #12 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xbe36a2)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #13 mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1200:11 (libxul.so+0xd97f77)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #14 non-virtual thunk to mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp (libxul.so+0xd99429)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #15 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1153:16 (libxul.so+0xbdc9ff)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #16 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xbe36a2)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #17 mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:330:5 (libxul.so+0x14acf28)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #18 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:335:10 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.080Z] 04:53:53     INFO -     #19 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:328:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #20 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:310:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #21 nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:395:10 (libxul.so+0xbd90a8)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #22 _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5 (libnspr4.so+0x44c06)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -   Previous write of size 1 at 0x7b5c001cac75 by main thread:
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #0 mozilla::net::nsSocketTransport::OpenInputStream(unsigned int, unsigned int, unsigned int, nsIInputStream**) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:2313:16 (libxul.so+0xd8de9a)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #1 non-virtual thunk to mozilla::net::nsSocketTransport::OpenInputStream(unsigned int, unsigned int, unsigned int, nsIInputStream**) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp (libxul.so+0xd8dfd6)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #2 NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:101 (libxul.so+0xc07f75)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #3 XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:925:10 (libxul.so+0x1aab2b0)
[task 2021-05-25T04:53:53.081Z] 04:53:53     INFO -     #4 <null> <null> (0x7f9d43f69b61)
[task 2021-05-25T04:53:53.082Z] 04:53:53     INFO -     #5 js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:386:32 (libxul.so+0x6b0c70e)
[task 2021-05-25T04:53:53.083Z] 04:53:53     INFO -     #6 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:544:13 (libxul.so+0x6b23db1)
[task 2021-05-25T04:53:53.083Z] 04:53:53     INFO -     #7 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:572:10 (libxul.so+0x6b24843)
[task 2021-05-25T04:53:53.085Z] 04:53:53     INFO -     #8 js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:589:8 (libxul.so+0x6b24843)
[task 2021-05-25T04:53:53.086Z] 04:53:53     INFO -     #9 JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jsapi.cpp:2733:10 (libxul.so+0x6fc7389)
[task 2021-05-25T04:53:53.088Z] 04:53:53     INFO -     #10 nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedJSClass.cpp:971:17 (libxul.so+0x1aa2419)
[task 2021-05-25T04:53:53.089Z] 04:53:53     INFO -     #11 PrepareAndDispatch /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:115:37 (libxul.so+0xc08f51)
[task 2021-05-25T04:53:53.089Z] 04:53:53     INFO -     #12 SharedStub <null> (libxul.so+0xc082b2)
[task 2021-05-25T04:53:53.091Z] 04:53:53     INFO -     #13 mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:482:16 (libxul.so+0xbeead7)
[task 2021-05-25T04:53:53.092Z] 04:53:53     INFO -     #14 mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:766:26 (libxul.so+0xbcba7a)
[task 2021-05-25T04:53:53.093Z] 04:53:53     INFO -     #15 mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:621:15 (libxul.so+0xbca202)
[task 2021-05-25T04:53:53.094Z] 04:53:53     INFO -     #16 mozilla::TaskController::ProcessPendingMTTask(bool) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:405:36 (libxul.so+0xbca3a4)
[task 2021-05-25T04:53:53.095Z] 04:53:53     INFO -     #17 operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:138:37 (libxul.so+0xbf29c7)
[task 2021-05-25T04:53:53.096Z] 04:53:53     INFO -     #18 mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:534:5 (libxul.so+0xbf29c7)
[task 2021-05-25T04:53:53.098Z] 04:53:53     INFO -     #19 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1159:16 (libxul.so+0xbdc720)
[task 2021-05-25T04:53:53.099Z] 04:53:53     INFO -     #20 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xbe36a2)
[task 2021-05-25T04:53:53.100Z] 04:53:53     INFO -     #21 mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:85:21 (libxul.so+0x14ac32d)
[task 2021-05-25T04:53:53.101Z] 04:53:53     INFO -     #22 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:335:10 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.102Z] 04:53:53     INFO -     #23 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:328:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.103Z] 04:53:53     INFO -     #24 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:310:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.104Z] 04:53:53     INFO -     #25 nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:137:27 (libxul.so+0x4b6d2f6)
[task 2021-05-25T04:53:53.105Z] 04:53:53     INFO -     #26 nsAppStartup::Run() /builds/worker/checkouts/gecko/toolkit/components/startup/nsAppStartup.cpp:273:30 (libxul.so+0x68cf8a8)
[task 2021-05-25T04:53:53.106Z] 04:53:53     INFO -     #27 XREMain::XRE_mainRun() /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5244:22 (libxul.so+0x69eacbf)
[task 2021-05-25T04:53:53.107Z] 04:53:53     INFO -     #28 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5442:8 (libxul.so+0x69eba07)
[task 2021-05-25T04:53:53.108Z] 04:53:53     INFO -     #29 XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5501:21 (libxul.so+0x69ebfa4)
[task 2021-05-25T04:53:53.109Z] 04:53:53     INFO -     #30 mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:45:12 (libxul.so+0x69f6562)
[task 2021-05-25T04:53:53.110Z] 04:53:53     INFO -     #31 do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:224:22 (firefox+0xca6e0)
[task 2021-05-25T04:53:53.111Z] 04:53:53     INFO -     #32 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:351:16 (firefox+0xca6e0)
[task 2021-05-25T04:53:53.112Z] 04:53:53     INFO -   Location is heap block of size 776 at 0x7b5c001cab80 allocated by thread T6:
[task 2021-05-25T04:53:53.113Z] 04:53:53     INFO -     #0 malloc /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:651:5 (firefox+0x55fbb)
[task 2021-05-25T04:53:53.114Z] 04:53:53     INFO -     #1 moz_xmalloc /builds/worker/checkouts/gecko/memory/mozalloc/mozalloc.cpp:52:15 (firefox+0xcc7eb)
[task 2021-05-25T04:53:53.115Z] 04:53:53     INFO -     #2 operator new /builds/worker/workspace/obj-build/dist/include/mozilla/cxxalloc.h:33:10 (libxul.so+0xd7ced4)
[task 2021-05-25T04:53:53.116Z] 04:53:53     INFO -     #3 mozilla::net::nsServerSocket::CreateClientTransport(PRFileDesc*, mozilla::net::NetAddr const&) /builds/worker/checkouts/gecko/netwerk/base/nsServerSocket.cpp:141:37 (libxul.so+0xd7ced4)
[task 2021-05-25T04:53:53.117Z] 04:53:53     INFO -     #4 mozilla::net::nsServerSocket::OnSocketReady(PRFileDesc*, short) /builds/worker/checkouts/gecko/netwerk/base/nsServerSocket.cpp:191:3 (libxul.so+0xd7d32e)
[task 2021-05-25T04:53:53.119Z] 04:53:53     INFO -     #5 mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>*) /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp (libxul.so+0xd98b1f)
[task 2021-05-25T04:53:53.120Z] 04:53:53     INFO -     #6 mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1160:7 (libxul.so+0xd97cc9)
[task 2021-05-25T04:53:53.121Z] 04:53:53     INFO -     #7 non-virtual thunk to mozilla::net::nsSocketTransportService::Run() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp (libxul.so+0xd99429)
[task 2021-05-25T04:53:53.121Z] 04:53:53     INFO -     #8 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1153:16 (libxul.so+0xbdc9ff)
[task 2021-05-25T04:53:53.122Z] 04:53:53     INFO -     #9 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xbe36a2)
[task 2021-05-25T04:53:53.122Z] 04:53:53     INFO -     #10 mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:330:5 (libxul.so+0x14acf28)
[task 2021-05-25T04:53:53.123Z] 04:53:53     INFO -     #11 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:335:10 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.123Z] 04:53:53     INFO -     #12 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:328:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.125Z] 04:53:53     INFO -     #13 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:310:3 (libxul.so+0x14364cc)
[task 2021-05-25T04:53:53.125Z] 04:53:53     INFO -     #14 nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:395:10 (libxul.so+0xbd90a8)
[task 2021-05-25T04:53:53.126Z] 04:53:53     INFO -     #15 _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5 (libnspr4.so+0x44c06)
[task 2021-05-25T04:53:53.126Z] 04:53:53     INFO -   Thread T6 'Socket Thread' (tid=1476, running) created by main thread at:
[task 2021-05-25T04:53:53.127Z] 04:53:53     INFO -     #0 pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:965:3 (firefox+0x577eb)
[task 2021-05-25T04:53:53.127Z] 04:53:53     INFO -     #1 _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14 (libnspr4.so+0x3be33)
[task 2021-05-25T04:53:53.128Z] 04:53:53     INFO -     #2 PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12 (libnspr4.so+0x30915)
[task 2021-05-25T04:53:53.128Z] 04:53:53     INFO -     #3 nsThread::Init(nsTSubstring<char> const&) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:613:18 (libxul.so+0xbda412)
[task 2021-05-25T04:53:53.129Z] 04:53:53     INFO -     #4 nsThreadManager::NewNamedThread(nsTSubstring<char> const&, unsigned int, nsIThread**) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:574:12 (libxul.so+0xbe252a)
[task 2021-05-25T04:53:53.129Z] 04:53:53     INFO -     #5 NS_NewNamedThread(nsTSubstring<char> const&, nsIThread**, already_AddRefed<nsIRunnable>, unsigned int) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:169:57 (libxul.so+0xbea354)
[task 2021-05-25T04:53:53.130Z] 04:53:53     INFO -     #6 NS_NewNamedThread<14> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:85:10 (libxul.so+0xd9667f)
[task 2021-05-25T04:53:53.131Z] 04:53:53     INFO -     #7 mozilla::net::nsSocketTransportService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:770:7 (libxul.so+0xd9667f)
[task 2021-05-25T04:53:53.131Z] 04:53:53     INFO -     #8 mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:10605:7 (libxul.so+0xba061f)
[task 2021-05-25T04:53:53.132Z] 04:53:53     INFO -     #9 mozilla::xpcom::StaticModule::CreateInstance(nsISupports*, nsID const&, void**) const /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:12095:10 (libxul.so+0xb9dad3)
[task 2021-05-25T04:53:53.132Z] 04:53:53     INFO -     #10 CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:177:46 (libxul.so+0xbb4c38)
[task 2021-05-25T04:53:53.133Z] 04:53:53     INFO -     #11 nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1276:17 (libxul.so+0xbb4c38)
[task 2021-05-25T04:53:53.133Z] 04:53:53     INFO -     #12 nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1465:10 (libxul.so+0xbb58a7)
[task 2021-05-25T04:53:53.134Z] 04:53:53     INFO -     #13 CallGetService /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:61:43 (libxul.so+0xbb876d)
[task 2021-05-25T04:53:53.135Z] 04:53:53     INFO -     #14 nsGetServiceByContractIDWithError::operator()(nsID const&, void**) const /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:253:21 (libxul.so+0xbb876d)
[task 2021-05-25T04:53:53.135Z] 04:53:53     INFO -     #15 nsCOMPtr_base::assign_from_gs_contractid_with_error(nsGetServiceByContractIDWithError const&, nsID const&) /builds/worker/checkouts/gecko/xpcom/base/nsCOMPtr.cpp:91:7 (libxul.so+0xaf7eb7)
[task 2021-05-25T04:53:53.136Z] 04:53:53     INFO -     #16 operator= /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:774:5 (libxul.so+0xd3b981)
[task 2021-05-25T04:53:53.136Z] 04:53:53     INFO -     #17 InitializeSocketTransportService /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:436:29 (libxul.so+0xd3b981)
[task 2021-05-25T04:53:53.141Z] 04:53:53     INFO -     #18 mozilla::net::nsIOService::SetOffline(bool) /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:1284:7 (libxul.so+0xd3b981)
[task 2021-05-25T04:53:53.143Z] 04:53:53     INFO -     #19 mozilla::net::nsIOService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:319:3 (libxul.so+0xd3ab9d)
[task 2021-05-25T04:53:53.143Z] 04:53:53     INFO -     #20 mozilla::net::nsIOService::GetInstance() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:493:9 (libxul.so+0xd3c741)
[task 2021-05-25T04:53:53.143Z] 04:53:53     INFO -     #21 mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:8740:48 (libxul.so+0xb9e33a)
[task 2021-05-25T04:53:53.143Z] 04:53:53     INFO -     #22 mozilla::xpcom::StaticModule::CreateInstance(nsISupports*, nsID const&, void**) const /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:12095:10 (libxul.so+0xb9dad3)
[task 2021-05-25T04:53:53.144Z] 04:53:53     INFO -     #23 CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:177:46 (libxul.so+0xbb4c38)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #24 nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1276:17 (libxul.so+0xbb4c38)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #25 nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1465:10 (libxul.so+0xbb58a7)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #26 CallGetService(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:61:43 (libxul.so+0xbb827d)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #27 CallGetService<nsIIOService> /builds/worker/workspace/obj-build/dist/include/nsServiceManagerUtils.h:52:10 (libxul.so+0x1bdaf55)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #28 nsScriptSecurityManager::Init() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1440:17 (libxul.so+0x1bdaf55)
[task 2021-05-25T04:53:53.147Z] 04:53:53     INFO -     #29 nsScriptSecurityManager::InitStatics() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1501:28 (libxul.so+0x1bdb551)
[task 2021-05-25T04:53:53.148Z] 04:53:53     INFO -     #30 nsXPConnect::InitStatics() /builds/worker/checkouts/gecko/js/xpconnect/src/nsXPConnect.cpp:154:3 (libxul.so+0x1ab1c03)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #31 xpcModuleCtor() /builds/worker/checkouts/gecko/js/xpconnect/src/XPCModule.cpp:11:3 (libxul.so+0x1a853e2)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #32 nsLayoutModuleInitialize() /builds/worker/checkouts/gecko/layout/build/nsLayoutModule.cpp:100:7 (libxul.so+0x53860eb)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #33 nsComponentManagerImpl::Init() /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:408:5 (libxul.so+0xbb071f)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #34 NS_InitXPCOM /builds/worker/checkouts/gecko/xpcom/build/XPCOMInit.cpp:445:51 (libxul.so+0xc19cfa)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #35 ScopedXPCOMStartup::Initialize(bool) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:1707:8 (libxul.so+0x69e0b1d)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #36 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5438:22 (libxul.so+0x69eb9f1)
[task 2021-05-25T04:53:53.151Z] 04:53:53     INFO -     #37 XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5501:21 (libxul.so+0x69ebfa4)
[task 2021-05-25T04:53:53.154Z] 04:53:53     INFO -     #38 mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:45:12 (libxul.so+0x69f6562)
[task 2021-05-25T04:53:53.154Z] 04:53:53     INFO -     #39 do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:224:22 (firefox+0xca6e0)
[task 2021-05-25T04:53:53.154Z] 04:53:53     INFO -     #40 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:351:16 (firefox+0xca6e0)
[task 2021-05-25T04:53:53.154Z] 04:53:53     INFO - SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransport2.cpp:1773:16 in OnMsgInputClosed
[task 2021-05-25T04:53:53.154Z] 04:53:53     INFO - ==================
[task 2021-05-25T04:53:53.184Z] 04:53:53     INFO - Exiting due to channel error.
[task 2021-05-25T04:53:53.193Z] 04:53:53     INFO - Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=23.9025) Exiting due to channel error.
[task 2021-05-25T04:53:53.194Z] 04:53:53     INFO - Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=334.758) Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=8.83387) [GFX1-]: Receive IPC close with reason=AbnormalShutdown
[task 2021-05-25T04:53:53.195Z] 04:53:53     INFO - Exiting due to channel error.
[task 2021-05-25T04:53:53.196Z] 04:53:53     INFO - Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=344.459) [GFX1-]: Receive IPC close with reason=AbnormalShutdown
[task 2021-05-25T04:53:53.197Z] 04:53:53     INFO - Exiting due to channel error.
[task 2021-05-25T04:53:54.238Z] 04:53:54    ERROR - TEST-UNEXPECTED-FAIL | image/test/crashtests/1676172-1.html | application terminated with exit code -6
[task 2021-05-25T04:53:54.265Z] 04:53:54     INFO - REFTEST INFO | Process mode: e10s
[task 2021-05-25T04:53:54.266Z] 04:53:54  WARNING - leakcheck | refcount logging is off, so leaks can't be detected!

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE

recent failure: https://treeherder.mozilla.org/logviewer?job_id=354279778&repo=autoland&lineNumber=2951

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

It seems that it is known that mInputClosed can be used from the main thread on initialization or shutdown. I would assume, that at least the state member variables are important enough to protect them better?

Flags: needinfo?(dd.mozilla)
Flags: needinfo?(dd.mozilla) → needinfo?(kershaw)
Group: core-security
Severity: S4 → --
Priority: P5 → --
Blocks: tsan
Group: core-security → network-core-security
Component: DOM: Networking → Networking
Keywords: csectype-race
Assignee: nobody → valentin.gosu
Severity: -- → S3
Flags: needinfo?(kershaw)
Priority: -- → P1
Whiteboard: [necko-triaged]

Make nsSocketTransport2::m{Input/Output}StreamClosed atomic r=necko-reviewers,kershaw,decoder
https://hg.mozilla.org/integration/autoland/rev/8ff01cedda9023f0408e9cfadb054ddd683c7378
https://hg.mozilla.org/mozilla-central/rev/8ff01cedda90

Group: network-core-security → core-security-release
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Please nominate this for Beta/ESR approval when you get a chance.

status-firefox93: --- → wontfix
status-firefox94: --- → affected
status-firefox-esr78: --- → wontfix
status-firefox-esr91: --- → affected
tracking-firefox94: --- → +
tracking-firefox95: --- → +
tracking-firefox-esr91: --- → 94+
Flags: needinfo?(valentin.gosu)

Comment on attachment 9245433 [details]
Bug 1712671 - Make nsSocketTransport2::m{Input/Output}StreamClosed atomic r=#necko

Beta/Release Uplift Approval Request

  • User impact if declined: Data race.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Difficult to reproduce manually.
  • List of other uplifts needed: Bug 1606864
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change makes variables atomic.
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration:
  • User impact if declined: Data race.
  • Fix Landed on Version: 95
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change makes variables atomic.
  • String or UUID changes made by this patch:
Flags: needinfo?(valentin.gosu)
Attachment #9245433 - Flags: approval-mozilla-esr91?
Attachment #9245433 - Flags: approval-mozilla-beta?

Comment on attachment 9245433 [details]
Bug 1712671 - Make nsSocketTransport2::m{Input/Output}StreamClosed atomic r=#necko

Approved for 94.0b9 and 91.3esr.

Attachment #9245433 - Flags: approval-mozilla-esr91?
Attachment #9245433 - Flags: approval-mozilla-esr91+
Attachment #9245433 - Flags: approval-mozilla-beta?
Attachment #9245433 - Flags: approval-mozilla-beta+
QA Whiteboard: [post-critsmash-triage]
Flags: qe-verify-
Whiteboard: [necko-triaged] → [necko-triaged][adv-main94+r]
Whiteboard: [necko-triaged][adv-main94+r] → [necko-triaged][adv-main94+r][adv-esr91.3+r]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: