Closed Bug 1712744 Opened 3 years ago Closed 3 years ago

Customize - My themes - theme circles appear pixelated and not centered

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Firefox 90
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- fix-optional

People

(Reporter: cfogel, Unassigned)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, regressionwindow-wanted, Whiteboard: [proton-toolbar])

Attachments

(2 files)

Attached image imgpsh_fullsize_anim.png (deleted) —

Affected versions

  • 90.0a1 (2021-05-25)

Affected platforms

  • Win10;

Steps to reproduce

  1. Launch Firefox, proton prefs enabled;
  2. Right click on toolbar and choose Customize Toolbar;
  3. Click on Themes dropdown;

Expected result

  • theme options properly displayed;

Actual result

  1. for theme options the inner color-demo appears to not be centered;
  2. (this might be as an enhancement, to increase density of points in circle so it's drawn more smooth);

Regression range

  • will poke DesktopQA team for further confirmations on this part;
  • if I recall right, it's visible with proton-related changes to the Themes menu(size increase);

Additional notes

  • attached screenshot to illustrate the issue.
QA Whiteboard: [qa-regression-triage]

Hi, I got the Following Regression range for this issue:

56:47.88 INFO: Last good revision: bf053d5617a4ec5f57aff3fa49ed9199d0f62841
56:47.88 INFO: First bad revision: 68a3d2c973a4b5eada6c25aad95647840a42fb88
56:47.88 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bf053d5617a4ec5f57aff3fa49ed9199d0f62841&tochange=68a3d2c973a4b5eada6c25aad95647840a42fb88
It seems that Bug 1706366 is the culprit but I think thats when they were implemented in the first place.

Ed Lee do you mind taking a look at this issue ?

Flags: needinfo?(edilee)
Regressed by: 1706366
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1706366

Attached image win10 customize theme 3360x2100 200% (deleted) —

Maybe this is sensitive to the screen resolution and OS zoom level? Seems okay for me on win10 3360x2100 200%

Flags: needinfo?(edilee)

I can reproduce on my screen on Win10 (2560x1440 @100%)

Priority: -- → P3

The Themes dropdown was removed from this page in bug 1729534, so I think this can be resolved WONTFIX.

Flags: needinfo?(gijskruitbosch+bugs)
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: