Closed Bug 1712775 Opened 3 years ago Closed 3 years ago

[Proton] One Off Area alignment issues

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
91 Branch
Iteration:
91.1 - May 31 - Jun 13
Tracking Flags:
Tracking Status
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: mehmet.sahin, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar])

Attachments

(4 files)

Text-Label_Actual_vs_Expected.png
(deleted), image/png
Details
One-Off-Buutons_Actual_vs_Expected_2.png
(deleted), image/png
Details
Bug 1712775 - Align one-off items with Urlbar icons. r?daisuke
(deleted), text/x-phabricator-request
Details
Verified_after_fix.png
(deleted), image/png
Details
Attached image Text-Label_Actual_vs_Expected.png (deleted) —

Nightly 90.0a1 (2021-05-25) (64-Bit)
macOS 11.4

Issue 1.) Take a look at the position of the "This time, search with" text label.
Issue 2.) Make the window small, so that the One Off buttons move below the text label.

Actual: Text label and One Off buttons are not aligned with the favicons above.

Expected: Text label could be moved by 3 px to the left and One Off buttons could be moved 6 px to the left to be aligned with the favicons above.

Screenshots are attached.

Thanks.

  • further screenshot
Blocks: proton-address-bar
Whiteboard: [proton-address-bar]
Severity: -- → S4
Points: --- → 2
Priority: -- → P3
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 91.1 - May 31 - Jun 13
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5db9b19863ea Align one-off items with Urlbar icons. r=daisuke

https://hg.mozilla.org/mozilla-central/rev/5db9b19863ea

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Attached image Verified_after_fix.png (deleted) —

Perfect, thanks! Looks as expected in Nightly 91.0a1 (2021-06-02) (64-Bit) on macOS 11.4 .

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(htwyford)

Uplift not needed. This also exists in other versions back to when we introduced the new look of the one-offs, which was many versions ago. This can ride the trains.

status-firefox90: affected → wontfix
Flags: needinfo?(htwyford)

Verified issues as fixed with Fx 91.0a1 on Windows 10x64, Ubuntu 16.4 and macOS 10.12.6.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: