Closed Bug 1713133 Opened 4 years ago Closed 3 years ago

The meatball menu from about:logins is improperly displayed when Increase contrast is enabled

Categories

(Firefox :: about:logins, defect, P3)

Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- verified
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- verified
firefox95 --- verified

People

(Reporter: danibodea, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Note

  • When the user ..., he will notice that...

Affected versions

  • Nightly v90.0a1
  • Beta v89.0 (RC)

Affected platforms

  • Mac OS

Steps to reproduce

  1. Launch browser.
  2. Load about:logins
  3. click the "meatballs menu" button

Expected result

  • The meatball menu is properly displayed.

Actual result

  • The meatball menu has some extra lines between buttons.

Regression range

  • It appears that this issue appeared when the background of the about:logins page is displayed in white, not black. (the theme is probably not relevant, but in case it is, default theme is System default, when the system is dark)

  • Regressor investigation:
    2021-05-27T17:15:23.320000: DEBUG : Found commit message:
    Bug 1705133 - add initial high contrast support for modals and notification bars, r=jaws

    We probably want to iterate on this, just like HCM support in general isn't really
    "finished", and we have better options now that we have better media query support
    for it, but this gets us pretty similar outcomes to the pre-proton state, and we
    should be able to build on that going forward.

    Differential Revision: https://phabricator.services.mozilla.com/D112344

    2021-05-27T17:15:23.320000: DEBUG : Did not find a branch, checking all integration branches
    2021-05-27T17:15:23.327000: INFO : The bisection is done.
    2021-05-27T17:15:23.442000: INFO : Stopped

Attached image demo for wrong meatball menu.png (deleted) —

Screenshot that demonstrates the issue:

Priority: -- → P3
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by itiel_yn8@walla.com: https://hg.mozilla.org/integration/autoland/rev/ea133af791e1 Don't apply borders on about:logins's menuitems r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

I have verified this issue using the latest Firefox Nightly 94.0a1 (Build ID: 20210930215026) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.

  • The Ellipsis menu is correctly displayed when the High Contrast mode is enabled. No extra borders are visible.
Status: RESOLVED → VERIFIED

Given that it's a one-liner CSS fix, please nominate this for ESR91.

Flags: needinfo?(itiel_yn8)

Comment on attachment 9242821 [details]
Bug 1713133 - Don't apply borders on about:logins's menuitems r?sfoster

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Visual issue for HCM users on about:logins, fix is one-liner CSS
  • User impact if declined: Visual issue for HCM users on about:logins- menuitems are displayed with extra and unneeded borders
  • Fix Landed on Version: 94
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One liner CSS fix
  • String or UUID changes made by this patch: None
Flags: needinfo?(itiel_yn8)
Attachment #9242821 - Flags: approval-mozilla-esr91?

Comment on attachment 9242821 [details]
Bug 1713133 - Don't apply borders on about:logins's menuitems r?sfoster

Approved for 91.3esr.

Attachment #9242821 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
Flags: qe-verify+

This issue has been verified on ESR v91.3.0esr and Nightly v95.0a1 on Mac OS 11.

Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: