Make mozilla::Unused unused
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
Before [[nodiscard]]
, you needed to do mozilla::Unused << expr
in order to properly mark an expression as unused. Now, we can just cast to (void)
.
This bug is for removing the deprecated mozilla::Unused
and preventing it from being added.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Comment 7•3 years ago
|
||
Whee, I spread out the reviews as a way to make sure people know.
See the thread https://groups.google.com/g/mozilla.dev.platform/c/0ySnEmxh12Y for what's going on here.
Thanks, cpeterson!
Comment 8•3 years ago
|
||
Nice! There are still 1000+ uses of Unused <<
in other directories, but your lint will keep that number from growing. Perhaps someday Unused
itself can be removed (bug 1628542).
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8a2d8249563 Convert uses of mozilla::Unused to void casts in gc/ r=jonco https://hg.mozilla.org/integration/autoland/rev/035615e942f1 Convert uses of mozilla::Unused to void casts in vm/ r=tcampbell https://hg.mozilla.org/integration/autoland/rev/0431e2e3f8f2 Convert uses of mozilla::Unused to void casts in jit/ r=iain https://hg.mozilla.org/integration/autoland/rev/0f7c74b50763 Convert uses of mozilla::Unused to void casts in wasm/ r=rhunt https://hg.mozilla.org/integration/autoland/rev/8137e1710fb5 Convert uses of mozilla::Unused to void casts in rest of JS code r=jandem https://hg.mozilla.org/integration/autoland/rev/eb812224c514 Add a check to prevent mozilla/Unused.h from being included r=mgaudet
Comment 10•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f8a2d8249563
https://hg.mozilla.org/mozilla-central/rev/035615e942f1
https://hg.mozilla.org/mozilla-central/rev/0431e2e3f8f2
https://hg.mozilla.org/mozilla-central/rev/0f7c74b50763
https://hg.mozilla.org/mozilla-central/rev/8137e1710fb5
https://hg.mozilla.org/mozilla-central/rev/eb812224c514
Assignee | ||
Comment 11•3 years ago
|
||
Comment 12•3 years ago
|
||
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/394f76022d39 followup - switch to DebugOnly<> to follow review comment
Comment 13•3 years ago
|
||
bugherder |
Description
•