Closed Bug 1713247 Opened 4 years ago Closed 4 years ago

Extract CardDAV discovery code so it can be reused

Categories

(MailNews Core :: Address Book, task)

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

CardDAV discovery is tied to the dialog box for creating a directory, but it should be accessible to the account set-up tab. In this bug I'll pull it and some other things out into a utility file.

Thank you so much for this, let me know if I can help in any way.

Even with these changes we still can't detect Google address books (or calendars, for that matter) without asking for authorisation again. I think I know what to do about that but I'll deal with it separately.

I guess it's good to get this in before the merge...

Target Milestone: --- → 91 Branch
Target Milestone: 91 Branch → 90 Branch

Hold that thought, I've found a problem.

Okay, I think we're good now. I've restored the old behaviour of always prompting for a username/password, even if there is one saved. Also I noticed that the username field wasn't disabled while looking for address books, so I fixed that too.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/beca85fcc20e
Move common CardDAV functions into a separate file. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5010bb05ba31
Extract CardDAV discovery code so it can be reused. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1715923
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: