Closed Bug 1713285 Opened 3 years ago Closed 3 years ago

Cleanups to prepare for bug 1704430

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(11 files)

Bug 1713285 part 1 - Rename PropertyInfo to PropertySnapshot. r?evilpie!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 2 - Rename ShapePropertyFlag{s} to PropertyFlag{s}. r?evilpie!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 3 - Rename ShapePropertyWithKey to PropertyInfoWithKey. r?evilpie!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 4 - Rename ShapeProperty to PropertyInfo. r?evilpie!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 5 - Rename ShapeProperty.h to PropertyInfo.h. r?evilpie!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 6 - Add vm/PropertyKey.h header. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 7 - Modernize vm/PropertyKey.h code. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 8 - Remove some unnecessary forward and friend declarations. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 9 - Move ObjectFlags out of Shape header files. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 10 - Simplify initial shapes table. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1713285 part 11 - Add ShapeZone. r?jonco!
(deleted), text/x-phabricator-request
Details

A collection of patches to prepare for later changes.

We want to use the naem PropertyInfo for ShapeProperty instead.

Also move the Vector type to ShapeProperty.h

Depends on D116225

Depends on D116226

This lets us move code out of Shape.h to simplify later changes.

Depends on D116228

Depends on D116229

This is similar to the BaseShape table: use WeakHeapPtr<Shape*> directly so
that we don't need the explicit fixup code for compacting GC.

Depends on D116232

Depends on D116233

Keywords: leave-open
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12db0e4b7fdf part 1 - Rename PropertyInfo to PropertySnapshot. r=evilpie https://hg.mozilla.org/integration/autoland/rev/c2be3188a644 part 2 - Rename ShapePropertyFlag{s} to PropertyFlag{s}. r=evilpie https://hg.mozilla.org/integration/autoland/rev/a2b8d2cfbec7 part 3 - Rename ShapePropertyWithKey to PropertyInfoWithKey. r=evilpie https://hg.mozilla.org/integration/autoland/rev/914921932cf3 part 4 - Rename ShapeProperty to PropertyInfo. r=evilpie https://hg.mozilla.org/integration/autoland/rev/ce2d267cdd4f part 5 - Rename ShapeProperty.h to PropertyInfo.h. r=evilpie
Keywords: leave-open
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6409fbf0834 part 6 - Add vm/PropertyKey.h header. r=jonco https://hg.mozilla.org/integration/autoland/rev/8ff57f540e79 part 7 - Modernize vm/PropertyKey.h code. r=jonco https://hg.mozilla.org/integration/autoland/rev/5e0df79afea0 part 8 - Remove some unnecessary forward and friend declarations. r=jonco https://hg.mozilla.org/integration/autoland/rev/e5260c512ea8 part 9 - Move ObjectFlags out of Shape header files. r=jonco https://hg.mozilla.org/integration/autoland/rev/82068f7ae696 part 10 - Simplify initial shapes table. r=jonco https://hg.mozilla.org/integration/autoland/rev/dc39afe35ec8 part 11 - Add ShapeZone. r=jonco
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: