Closed
Bug 1713522
Opened 3 years ago
Closed 3 years ago
netwerk/protocol/http/nsHttpConnection.cpp: do not use 'else' after 'return'
Categories
(Core :: Networking: HTTP, task, P5)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: surajeet310)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++][necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/netwerk/protocol/http/nsHttpConnection.cpp#2620-2623
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Reporter | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P5
Whiteboard: [lang=C++] → [lang=C++][necko-triaged]
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D115999
|
||
Updated•3 years ago
|
Assignee: nobody → surajeet310
Status: NEW → ASSIGNED
|
|
||
Updated•3 years ago
|
Attachment #9224323 -
Attachment description: Bug 1713522 -Removed else after return in nsHttpConnection.cpp .r=Sylvestre and jstutte → Bug 1713522 - Removed else after return in nsHttpConnection.cpp r=dragana
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f6f1021450d
Removed else after return in nsHttpConnection.cpp r=necko-reviewers,dragana
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•