Closed
Bug 1713525
Opened 3 years ago
Closed 3 years ago
xpcom/base/nsTraceRefcnt.cpp: do not use 'else' after 'return'
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: aravind.ar786)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(2 files)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/xpcom/base/nsTraceRefcnt.cpp#505-512
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Updated•3 years ago
|
Assignee: nobody → aravind.ar786
Status: NEW → ASSIGNED
|
|
||
Updated•3 years ago
|
Attachment #9227955 -
Attachment description: Bug 1713525 - removed 'else' after 'return'. r=gerald,nika,bobowen,jld → Bug 1713525 - removed 'else' after 'return'. r=gerald
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06e1cf8c66ad
removed 'else' after 'return'. r=gerald
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•