Closed Bug 1713544 Opened 3 years ago Closed 3 years ago

Introduce CompositorTransform and store CompositeTiles in local space

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: gw, Assigned: gw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1703709

Store CompositeTile instances in local space, and add support for compositor
transforms that can map local -> raster -> device space without access to the
spatial tree.

This is prep work for supporting picture cache tiles that are scaled by the
composite step during pinch-zoom, for low-end GPUs. Follow up patches will
port the native compositor surface and external descriptors to also work
in local space, converting to raster or device space on demand as required.

Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9449ea40b4fd Introduce CompositorTransform and store CompositeTiles in local space. r=gfx-reviewers,lsalzman

Backed out along with Bug 1711648 as it was causing backout conflicts.

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1711648#c15

Flags: needinfo?(gwatson)
Backout by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b76629289c9 Backed out 3 changesets (bug 1713544, bug 1711648) for valgrind failures. CLOSED TREE

This patch was backed out due to causing merge conflicts when backing out an earlier patch. Trying to re-land this patch now without changes, since the preceding patch has been fixed and re-landed.

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ce1b7de9a7c Introduce CompositorTransform and store CompositeTiles in local space. r=gfx-reviewers,lsalzman

The failure is that it fails to decode an updated PNG file. However, the wrench jobs pass just fine and are all green on my local machine, and also on a try run (https://treeherder.mozilla.org/jobs?repo=try&revision=ca14f1fd88a0ab9c4e14413818b4d6b05f451e9f).

I'm going to try re-land the patch as-is, to see if it's some kind of intermittent CI flakiness.

If not, there might be some image file corruption going on somewhere between phabricator -> lando -> autoland perhaps?

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5452bb0b5363 Introduce CompositorTransform and store CompositeTiles in local space. r=gfx-reviewers,lsalzman
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Regressions: 1714487

There is a bisected regression for this (https://bugzilla.mozilla.org/show_bug.cgi?id=1714487). I probably won't be able to look into it until Monday. If it's rare it can probably wait until then. If it's more urgent than that, please feel free to back it out over the weekend.

Flags: needinfo?(nical.bugzilla)
Flags: needinfo?(jmuizelaar)
Depends on: 1714502
Regressions: 1714502
Status: RESOLVED → REOPENED
Flags: needinfo?(gwatson)
Resolution: FIXED → ---
Target Milestone: 91 Branch → ---

Updated the patch to correct the regressions in #1714502 and #1714487.

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4878547fc48 Introduce CompositorTransform and store CompositeTiles in local space. r=gfx-reviewers,lsalzman
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: needinfo?(nical.bugzilla)
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: