Closed
Bug 1713635
Opened 3 years ago
Closed 3 years ago
Interventions on android-components broken
Categories
(Web Compatibility :: Interventions, defect, P1)
Web Compatibility
Interventions
Tracking
(firefox91 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: denschub, Assigned: twisniewski)
References
Details
Attachments
(2 files)
Currently, the interventions (and shims) are broken in android-components, because the interventions addon fails to load. inside run.js
, it throws:
Uncaught Error: Incorrect argument types for tabs.onUpdated.
_registerShims moz-extension://145ff6a9-410e-4cda-8534-fca729695095/lib/shims.js:347
Shims moz-extension://145ff6a9-410e-4cda-8534-fca729695095/lib/shims.js:294
<anonymous> moz-extension://145ff6a9-410e-4cda-8534-fca729695095/run.js:13
This code was added recently (in bf48ec7
, and appears to be working fine on desktop afaict.
Reporter | ||
Comment 1•3 years ago
|
||
Also, proposal: We probably should wrap each component (interventions, uaoverrides, shims, aboutcompat-broker) into their own try-catch block. It's not great if, for example, shims break - but if other interventions could keep working, that'd be better.
Reporter | ||
Updated•3 years ago
|
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
The problem is that on Fenix the tabs.onUpdated.addListener
doesn't accept the properties parameter. I can work around this easily enough, patch incoming.
Assignee | ||
Comment 3•3 years ago
|
||
Pushed by dschubert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7be7437c9df
Work around a lack of support for the properties parameter of browser.tabs.onUpdated in GeckoView, so the webcompat addon starts up properly there; r=denschub,webcompat-reviewers
Reporter | ||
Comment 5•3 years ago
|
||
Submitted a PR for android-components before this landed in central to speed up the process a bit.
Comment 6•3 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•