Closed Bug 1713694 Opened 3 years ago Closed 3 years ago

Add an ETP shim for AddThis

Categories

(Core :: Privacy: Anti-Tracking, enhancement)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: twisniewski, Assigned: twisniewski)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1713694 - Add a SmartBlock shim for AddThis; r?denschub
(deleted), text/x-phabricator-request
Details
Bug 1713694 - update the SmartBlock shim for AddThis to load an empty Angular module instead as needed; r?denschub
(deleted), text/x-phabricator-request
Details

Even just shimming it with an empty will prevent some sites from completely breaking.

Blocks: 1700986
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43af938350db Add a SmartBlock shim for AddThis; r=denschub,webcompat-reviewers

Pardon the bad merge! I've fixed the patch and will wait for SCA like a good boy this time!

Flags: needinfo?(twisniewski)

Please also check bc failures on browser_parsable_script.js -> https://treeherder.mozilla.org/logviewer?job_id=348700881&repo=autoland&lineNumber=2989

Flags: needinfo?(twisniewski)
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60460b50e794 Add a SmartBlock shim for AddThis; r=denschub,webcompat-reviewers

https://hg.mozilla.org/mozilla-central/rev/60460b50e794

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

It turns out that we'll need to do something a bit different than expected to fix the breakage we're seeing with the AddThis widget's angular module; an empty script shim isn't sufficient. I have a follow-up patch ready which addresses this.

Status: RESOLVED → REOPENED
Flags: needinfo?(twisniewski)
Resolution: FIXED → ---
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/31d44c4124c1 update the SmartBlock shim for AddThis to load an empty Angular module instead as needed; r=denschub,webcompat-reviewers

https://hg.mozilla.org/mozilla-central/rev/31d44c4124c1

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox93: affected → fixed
Resolution: --- → FIXED
Blocks: 1731910
No longer blocks: 1731910
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: