Tests skipped in 'browser/components/extensions/test/browser/browser.ini' for new Fission platform triage
Categories
(WebExtensions :: Untriaged, task, P3)
Tracking
(Fission Milestone:MVP, firefox-esr78 disabled, firefox89 disabled, firefox90 disabled, firefox91 disabled, firefox92 fix-optional)
People
(Reporter: ahal, Assigned: zombie)
References
(Blocks 1 open bug)
Details
(Whiteboard: fission-soft-blocker)
Attachments
(2 files)
The following tests were disabled in browser/components/extensions/test/browser/browser.ini due to new Fission platform triage:
browser_ext_devtools_inspectedWindow_reload.js
unknown
Full diff:
diff --git a/browser/components/extensions/test/browser/browser.ini b/browser/components/extensions/test/browser/browser.ini
--- a/browser/components/extensions/test/browser/browser.ini
+++ b/browser/components/extensions/test/browser/browser.ini
@@ -38,16 +39,18 @@ support-files =
webNav_createdTargetSource.html
webNav_createdTargetSource_subframe.html
searchSuggestionEngine.xml
searchSuggestionEngine.sjs
../../../../../toolkit/components/extensions/test/mochitest/head_webrequest.js
../../../../../toolkit/components/extensions/test/mochitest/redirection.sjs
../../../../../toolkit/components/reader/test/readerModeNonArticle.html
../../../../../toolkit/components/reader/test/readerModeArticle.html
+skip-if =
+ fission && os == "linux" && asan # New platform triage
[browser_ExtensionControlledPopup.js]
[browser_ext_addon_debugging_netmonitor.js]
[browser_ext_autocompletepopup.js]
disabled = bug 1438663 # same focus issue as Bug 1438663
[browser_ext_autoplayInBackground.js]
[browser_ext_browserAction_area.js]
[browser_ext_browserAction_experiment.js]
@@ -100,16 +103,17 @@ support-files = !/browser/components/pla
[browser_ext_contextMenus_targetUrlPatterns.js]
[browser_ext_contextMenus_uninstall.js]
[browser_ext_contextMenus_urlPatterns.js]
[browser_ext_currentWindow.js]
[browser_ext_devtools_inspectedWindow.js]
[browser_ext_devtools_inspectedWindow_eval_bindings.js]
[browser_ext_devtools_inspectedWindow_eval_file.js]
[browser_ext_devtools_inspectedWindow_reload.js]
+skip-if = fission && os == 'mac' && !debug # New platform triage
[browser_ext_devtools_inspectedWindow_targetSwitch.js]
[browser_ext_devtools_network.js]
skip-if = fission || os == 'linux' || (os == 'mac' && debug) || (debug && os == 'win' && bits == 64) # Bug1570478
[browser_ext_devtools_network_targetSwitch.js]
[browser_ext_devtools_optional.js]
[browser_ext_devtools_page.js]
[browser_ext_devtools_page_incognito.js]
[browser_ext_devtools_panel.js]
See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8
To run these failures in your own try push, first revert the skip-if
annotations, then run:
$ ./mach try fuzzy --rebuild 3 browser/components/extensions/test/browser/browser.ini
Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if
expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.
Comment 1•3 years ago
|
||
We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).
Here is a recent Try run for Fission browser-chrome:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8
Comment 2•3 years ago
|
||
The linux64 asan failure appears to not be able to run properly on treeherder due to some infrastructure failure. ni? :ahal to find a test run which shows the type of failures occurring here.
I can't find a reproduction for the browser_ext_devtools_inspectedWindow_reload.js
failure on opt macos.
Reporter | ||
Comment 3•3 years ago
|
||
Let's see if we can reproduce in this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e4ac313dac903a92b953fc52d17b7eb28c8cf03
If not we can use this bug to revert the annotations.
Reporter | ||
Comment 4•3 years ago
|
||
Looks like the macosx annotation can be reverted, but I see a bunch of failures starting to pop-up for asan. Specifically this one is not tied to any test:
https://treeherder.mozilla.org/logviewer?job_id=341671794&repo=try&lineNumber=7028
Which is likely why the whole manifest got skipped. I realize now that is what you were asking about.. I don't really know anything about AddressSanitizer, so redirecting to :decoder.
Comment 5•3 years ago
|
||
The linked ASan failure is not ASan specific. It is simply a crash in RunWatchdog
indicating a hang. This will likely happen with other builds that are equally slow, increasing the respective timeouts might help (or there is a real intermittent hang of some sort, but you should see this on other platforms too, just that it manifests differently). You might also see this if the test uses abnormal amounts of memory (in that case, sanitizers are more likely to cause slowdowns).
Comment 6•3 years ago
|
||
zombie, if I am reading the above comments correctly, it sounds like we just need to increase this test's timeout and remove the new Fission annotations from comment 0.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 7•3 years ago
|
||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 10•3 years ago
|
||
All test disabled in bug 1694824 are back running in the default Fission configuration, the only thing left here is ASAN, which is unlikely to have anything to do with extensions code.
I don't want to be extending timeouts for the whole suite, but don't have time now to push individual tests to see which ones actually need it.
In any case, I don't think what's left here needs to block M7a anymore, so I would either move it out, or resolve this and file another bug.
Chris, what would be preferable here?
Assignee | ||
Comment 11•3 years ago
|
||
oops, not what I wanted.
Comment 12•3 years ago
|
||
Per zombie's findings in comment 10, moving this one out to M8.
Comment 13•3 years ago
|
||
Tomislav, what work is remaining for this bug?
The following tests are still disabled for Fission in browser/components/extensions/test/browser/browser.ini:
All tests are skipped on Fission Linux ASan:
skip-if =
fission && os == "linux" && asan # Bug 1713895 - new Fission platform triage
And you just posted a patch for review to fix the browser_ext_tabs_discard_reversed.js test in bug 1717872:
[browser_ext_tabs_discard_reversed.js]
skip-if = fission # bug 1717872
Comment 14•3 years ago
|
||
This bug is a soft blocker for Fission M8. We'd like to fix it before our M8 Release experiment, but we won't delay the experiment waiting for it.
Assignee | ||
Comment 15•3 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #13)
Tomislav, what work is remaining for this bug?
I just fixed bug 1717872, and I'm looking what/how to adjust timeouts for ASAN builds next. I agree this doesn't need to block M8, but I want to fix it.
Comment 16•3 years ago
|
||
(In reply to Tomislav Jovanovic :zombie from comment #15)
I just fixed bug 1717872, and I'm looking what/how to adjust timeouts for ASAN builds next. I agree this doesn't need to block M8, but I want to fix it.
In that case, I'll move this bug to Fission Milestone MVP since we want to fix it soon but it doesn't affect Release experiment (M8).
Assignee | ||
Comment 17•3 years ago
|
||
Also fix to actually call the correct requestLongerTimeout() method,
and shorten the timeout by half to see if That would be enough.
Comment 18•3 years ago
|
||
Comment 19•3 years ago
|
||
bugherder |
Comment 20•3 years ago
|
||
Comment 21•3 years ago
|
||
Comment 22•3 years ago
|
||
bugherder |
Assignee | ||
Comment 23•3 years ago
|
||
This was originally about tests disabled with Fission, and that was mostly if not completely addressed, though since bug 1721945 they are now disabled again because of Software WebRender (regardless of Fission), so closing this as a Fission blocker.
Updated•3 years ago
|
Description
•