Closed Bug 1714017 Opened 3 years ago Closed 3 years ago

32.24 - 30.95% displaylist_mutate / displaylist_mutate (Linux) regression on Wed May 26 2021

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Version:
Firefox 91
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1713409
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- fixed
firefox91 --- fixed

People

(Reporter: alexandrui, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push f412f8f6803751c9fcf8ffcbde4784917049b673. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
32% displaylist_mutate (docs) linux1804-64-shippable-qr e10s stylo webrender-sw 2,504.59 -> 3,311.94
31% displaylist_mutate (docs) linux1804-64-shippable-qr e10s stylo webrender-sw 2,520.60 -> 3,300.67

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
10% perf_reftest (docs) some-descendants-1.html linux1804-64-shippable-qr e10s stylo webrender-sw 4.90 -> 4.40

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(gwatson)

Set release status flags based on info from the regressing bug 1712871

status-firefox89: --- → unaffected
status-firefox90: --- → affected
status-firefox-esr78: --- → unaffected

I think this was probably fixed by the follow up patch Lee landed to fix a bug from this patch where max_update_rects would end up being 0 on sw-wr. Apart from that bug, this should have been a simple refactoring patch with no impact on performance. Lee, does that sound right to you?

Flags: needinfo?(gwatson) → needinfo?(lsalzman)

That was addressed in my follow-up and should be resolved now.

Flags: needinfo?(lsalzman)
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: affected → fixed
status-firefox91: affected → fixed
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.