Closed Bug 1714079 Opened 3 years ago Closed 3 years ago

"Send Tab to Device" does not show success feedback if account button is within Overflow menu

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Version:
Firefox 89
Platform:
Desktop
All
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- wontfix
firefox92 --- fixed

People

(Reporter: itob.dev+bugzilla, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Bug 1714079, send confirmation does not appear when sending a tab when the account button is in the overflow menu, r=mstriemer
(deleted), text/x-phabricator-request
Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

  1. Sign in to Firefox account.
  2. Move "Firefox account" toolbar button into the "Overflow Menu"
  3. Send any tab to another device

Actual results:

No visual indication appears that the operation succeeded.

Tested with Firefox 89.0 (64-bit) on Windows 10 as well as a clean installation of Firefox Nightly 91.0a1 (2021-06-01) (64-bit).

Expected results:

A visual indicator (tick mark with text "Sent!" next to application menu toolbar button) should be shown as is the case when the Firefox account toolbar button is completely removed.
(Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1701544)

The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Toolbars and Customization
Blocks: proton-cleanups
Severity: -- → S4
OS: Unspecified → All
Hardware: Unspecified → Desktop
Whiteboard: [proton-cleanups]

Thanks for the report! I can also reproduce this on all the latest Firefox versions on MacOS 10.15, marking affected flags accordingly.

Status: UNCONFIRMED → NEW
status-firefox89: --- → affected
status-firefox90: --- → affected
status-firefox91: --- → affected
Ever confirmed: true
Points: --- → 1
Priority: -- → P3
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4da1575d7b9 send confirmation does not appear when sending a tab when the account button is in the overflow menu, r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/b4da1575d7b9

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: