Apply fix from bug 1706261 to the libwebrtc import from bug 1654112
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Tracking
()
People
(Reporter: bwc, Assigned: gaston)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details |
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
afaict the problem shown in bug 1706261 is still valid with newer webrtc so https://phabricator.services.mozilla.com/D116746 should be reapplied to https://searchfox.org/mozilla-central/source/third_party/libwebrtc/rtc_base/platform_thread.cc#187 in beta & m-c ?
|
|
Assignee | |
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]: reapply the fix from bug #1706261 after bug #1654112 that landed for 96
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
attachment backports/reapplies https://phabricator.services.mozilla.com/D116746 on top of the webrtc update.
|
Reporter | |
Comment 5•3 years ago
|
||
Let's see if I can just re-land that phabricator revision.
|
|
Reporter | |
Comment 6•3 years ago
|
||
|
|
Reporter | |
Comment 7•3 years ago
|
||
|
|
Reporter | |
Comment 8•3 years ago
|
||
Unfortunately cannot simply re-land, since the file moved. Will need to go through the phabricator dance one more time.
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d32376777978 Re-apply fix from bug 1706261 that was lost in bug 1654112. r=ng
|
|
Assignee | |
Comment 10•3 years ago
|
||
thanks a lot !
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 13•3 years ago
|
||
Comment on attachment 9256165 [details]
Bug 1714115: Re-apply fix from bug 1706261 that was lost in bug 1654112. r?ng
Beta/Release Uplift Approval Request
- User impact if declined: fix race conditions leading to tab crashes with multiple connecting webrtc clients (eg bug #1706261)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): not risky as it's been shipped to all users for the previous webrtc lifetime
- String changes made/needed: none
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 14•3 years ago
|
||
Comment on attachment 9256165 [details]
Bug 1714115: Re-apply fix from bug 1706261 that was lost in bug 1654112. r?ng
Approved for 96.0b8
|
|
||
Comment 15•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Description
•