User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

• Gnome Desktop (Fedora Workstation 33) - Linux
• System Theme Adwaita or Adwaita Dark
• Firefox Choose Dark Theme.

Actual results:

'X' / 'close button' sometimes is dark with no proper contrast, screenshot provided.

Expected results:

'X' / 'close button' should be light color to provide contrast with dark theme.

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Clarification: what is happening:

• Firefox Dark Theme with Adwaita Light as system theme: 'x' button is dark when it should be light.
• Firefox Light Theme with Adwaita Dark as system theme: 'x' button is light when it should be dark.

Either way there is no contrast.

So looks like Firefox light/dark theme is 'borrowing' the 'x' button from the system theme but can't see that I'm not always using the matching light/dark variant.

This happens frequently because I have an extension that changes my theme automatically but Firefox remains to be adjusted manually.

So this is kind of related to Bug 1627757

This is sorta like bug 1707872. The close buttons are native so they use the system theme, but we don't have the capability to auto-switch between the two variants...

Markus, what was the relevant bug for macOS respect-system-appearance? That plus some theme switching on GTK would fix it.

(Late reply, but the bug ended up being bug 1715145.)

Here reports a regression after Bug 1707872 fix [1] on KDE, which seems to be related to this bug.

1. https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=feaff6bddf649886164bfb5897dbf33b8789d930&tochange=0e6c67113ca7dba2de8101156993c563da62a3a1

Can you file a new bug for that with details about which gtk theme are you using? You can use MOZ_LOG=LookAndFeel:5 /path/to/nightly/firefox to figure out.

This works after bug 1707872 as expected (at least on Gnome), can you confirm?

(In reply to Outvi V from comment #5)

Created attachment 9226740 [details]
kde-close-button-hover.png

Here reports a regression after Bug 1707872 fix [1] on KDE, which seems to be related to this bug.

1. https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=feaff6bddf649886164bfb5897dbf33b8789d930&tochange=0e6c67113ca7dba2de8101156993c563da62a3a1

I tried to reproduce that with various combinations of light / dark Firefox and GTK themes on Plasma and didn't succeed, fwiw. But will try again once more info is available, thanks!

Hi Emilio, I've created Bug 1716285 and appended the related information.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

This works after bug 1707872 as expected (at least on Gnome), can you confirm?

Firefox 91.0a1 (2021-06-16) (64-bits) is working correctly. Thanks!

I believe this issue can be closed.