Closed
Bug 1714242
Opened 3 years ago
Closed 3 years ago
Rename settingsButtonCompact variable with settingsButton in SearchOneOffs.jsm
Categories
(Firefox :: Search, task, P3)
Tracking
()
RESOLVED
FIXED
92 Branch
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a follow-up for bug 1709405.
We have removed the compact mode for the settings button in bug 1709405, want to rename the variable settingsButtonCompact with settingsButton.
https://searchfox.org/mozilla-central/search?q=settingsButtonCompact&path=&case=true®exp=false
However, we could not rename it since renaming the variable caused a test failure.
https://phabricator.services.mozilla.com/D115772#3794436
If possible, we want to find the reason why renaming causes the error, then fix it.
|
||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e9e40d668c1
Rename settingsButtonCompact with settingsButton. r=harry
|
||
Comment 3•3 years ago
|
||
Backed out for causing bc failures on browser_urlbar_event_telemetry_noEvent.js.
Flags: needinfo?(daisuke)
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/568df46713fe
Rename settingsButtonCompact with settingsButton. r=harry
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•