Closed
Bug 1714299
Opened 3 years ago
Closed 3 years ago
Correct ORB's opaque response implementation
Categories
(Core :: DOM: Networking, defect, P2)
Core
DOM: Networking
Tracking
()
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: annevk, Assigned: edenchuang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
As discussed offline the telemetry for ORB is somewhat off due to incorrectly identifying opaque responses. We should correct this and then observe if the telemetry becomes more in line with what would be expected.
In particular, an opaque response depends on request's mode (has to be "no-cors"), and depends on whether there was ever a cross-origin response to the request (i.e., a redirect chain of A -> B -> A results in an opaque response).
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee | ||
Updated•3 years ago
|
Severity: S3 → S2
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [necko-triaged]
Assignee | ||
Updated•3 years ago
|
Severity: S2 → S3
Priority: P1 → P2
Assignee | ||
Updated•3 years ago
|
Whiteboard: necko-triaged
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Attachment #9225734 -
Attachment description: Bug 1714299 - Fix the opaque response judgment for opaque response blocking. → Bug 1714299 - Correct the opaque response judgment for opaque response blocking.
Updated•3 years ago
|
Whiteboard: necko-triaged → [necko-triaged]
Pushed by echuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e9693e4d6b7
Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana
Comment 3•3 years ago
|
||
Backed out for causing high frequency failures on browser_opaque_response_blocking_telemetry.js
-
backout: https://hg.mozilla.org/integration/autoland/rev/a1d7eb08b69621ad798af9e3f37c26be430a1cef
-
failure log: https://treeherder.mozilla.org/logviewer?job_id=343485993&repo=autoland&lineNumber=5893
[task 2021-06-22T14:55:01.998Z] 14:55:01 INFO - TEST-PASS | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo -
[task 2021-06-22T14:55:01.999Z] 14:55:01 INFO - Fetching cross-origin url: https://example.com/browser/netwerk/test/browser//res_object.html.
[task 2021-06-22T14:55:01.999Z] 14:55:01 INFO - Validating if the telemetry probe has been reported.
[task 2021-06-22T14:55:02.000Z] 14:55:01 INFO - Buffered messages finished
[task 2021-06-22T14:55:02.001Z] 14:55:02 INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo -
[task 2021-06-22T14:55:02.001Z] 14:55:02 INFO - Stack trace:
[task 2021-06-22T14:55:02.001Z] 14:55:02 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-06-22T14:55:02.001Z] 14:55:02 INFO - chrome://mochitests/content/browser/netwerk/test/browser/browser_opaque_response_blocking_telemetry.js:null:225
[task 2021-06-22T14:55:02.216Z] 14:55:02 INFO - Fetching cross-origin url: https://example.org/browser/netwerk/test/browser/res_img.png.
[task 2021-06-22T14:55:02.241Z] 14:55:02 INFO - Validating if the telemetry probe has been reported.
[task 2021-06-22T14:55:02.242Z] 14:55:02 INFO - TEST-PASS | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo -
Flags: needinfo?(echuang)
Pushed by echuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f694fff24c46
Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana
Comment 5•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(echuang)
Updated•2 years ago
|
Whiteboard: [necko-triaged] → [necko-triaged][sp3]
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-153
Updated•2 years ago
|
See Also: https://mozilla-hub.atlassian.net/browse/SP3-153 →
Whiteboard: [necko-triaged][sp3] → [necko-triaged]
You need to log in
before you can comment on or make changes to this bug.
Description
•