Jared noted in https://phabricator.services.mozilla.com/D116630#inline-647659 that we only appear to ever set this property to true.

I think when I reviewed https://phabricator.services.mozilla.com/D116246 , I noticed that some notifications do not pass this. Mike, do you know if we can remove this, and/or can perhaps make the default to not show the highlight and have callers that want a highlighted button opt-in, instead of all the other ones opting out?

Oops, looks like I got some wires crossed, this is about PopupNotifications, not doorhangers.

I think disableHighlight is safe to remove. That was mainly to make it possible to not highlight the primary button for PopupNotifications that are created imparitively, and for those, I think all of them now default to disableHighlight: true behaviour with Proton enabled.

There are some exceptions, but I believe they're all PopupNotifications that are created declaratively, and have a buttonhighlight="true" attribute, like: https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/customizableui/content/panelUI.inc.xhtml#107

Thanks Mike!

https://hg.mozilla.org/mozilla-central/rev/1913dbd50ba3