Closed Bug 1714337 Opened 3 years ago Closed 3 years ago

Unify gHighPriorityNotificationBox and gNotificationBox now that they're always the same

Categories

(Firefox :: Toolbars and Customization, task, P3)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
Desktop
All
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox91 --- wontfix
firefox92 --- fixed

People

(Reporter: Gijs, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Bug 1714337, remove separate high and non-high notification box references, r=mstriemer
(deleted), text/x-phabricator-request
Details

Bug 1711519 removes the non-proton case for the separate notification box. We should probably just rename the HighPriority one and use only gNotificationBox everywhere, instead of having 2 ways of referencing the same thing. Mark, is that right, or am I missing something? And was I right in thinking there was no markup to clean up from that, as they were both created on an as-needed basis? Is there CSS left that is specific to the non-proton "low priority" notification box that should be removed?

Flags: needinfo?(mstriemer)
Severity: -- → N/A
Points: --- → 3
Priority: -- → P3
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5eb3923bbf34 remove separate high and non-high notification box references, r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/5eb3923bbf34

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
status-firefox91: affected → wontfix
Flags: needinfo?(mstriemer)
Blocks: 1802142
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: