Teach WebRTC.org to use the Gecko Profiler
Categories
(Core :: WebRTC, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(11 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
image/png
|
Details |
webrtc-profile-decode.png
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
This allows using the Gecko Profiler without pulling in half of Gecko (nsTArray,
nsString, etc.). This is for use in third party code, that we lightly patch to
register the threads.
Depends on D116838
|
|
Assignee | |
Comment 3•3 years ago
|
||
This is the only change that is needed, and is trivial to rebase if this file
changes. I don't know if there is value in providing the raw patch file
alongside this commit, like we sometimes do?
Depends on D116839
|
|
Assignee | |
Comment 4•3 years ago
|
||
This is just ./mach build-backend -b GnMozbuildWriter with the change in Part 1.
Depends on D116840
|
|
Assignee | |
Comment 5•3 years ago
|
||
We're going to modify it, but it will cause unnecessary churn to reformat it to
Gecko style (it would change all indentation, etc.), in case we want to update
it with upstream.
Depends on D116841
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D116842
|
|
Assignee | |
Comment 7•3 years ago
|
||
Depends on D116843
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D116844
|
|
Assignee | |
Comment 9•3 years ago
|
||
Depends on D116845
|
|
Assignee | |
Comment 10•3 years ago
|
||
Depends on D116846
|
|
Assignee | |
Comment 11•3 years ago
|
||
This is how it looks like in the end, when using the profile Media and recording a WebRTC call.
|
||
Updated•3 years ago
|
|
||
Comment 12•3 years ago
|
||
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79db0c37af56 Part 1 - Include the Gecko Profiler include directory in WebRTC.org files. r=ng https://hg.mozilla.org/integration/autoland/rev/b2767ca4b806 Part 2 - Introduction of the micro gecko profiler API. r=gerald https://hg.mozilla.org/integration/autoland/rev/7c5c4bce1b36 Part 3 - Register WebRTC threads with the Gecko Profiler. r=ng https://hg.mozilla.org/integration/autoland/rev/782e6df9b4c8 Part 4 - Regenerate `moz.build` files to add the new include directory. r=ng https://hg.mozilla.org/integration/autoland/rev/e805cbb61030 Part 5 - Add GeckoTraceEvent.h to clang-format-ignore. r=gerald https://hg.mozilla.org/integration/autoland/rev/837b6ce8367b Part 6 - Copy WebRTC's trace_event.h to Gecko, verbatim, and redirect the original trace_event.h to it. r=gerald https://hg.mozilla.org/integration/autoland/rev/e296aab6c841 Part 7 - Add a function to insert a very simple profiler marker in the micro gecko profiler. r=gerald https://hg.mozilla.org/integration/autoland/rev/258640cc1188 Part 8 - Modify GeckoTraceEvent.h to use the micro gecko profiler API. r=gerald https://hg.mozilla.org/integration/autoland/rev/2b9472a516eb Part 9 - Video capture code also has tracing macros. r=ng https://hg.mozilla.org/integration/autoland/rev/cd6d06ee89dd Part 10 - Add (some?) WebRTC threads to the firefox profiler. r=julienw,gerald
|
||
Comment 13•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/79db0c37af56
https://hg.mozilla.org/mozilla-central/rev/b2767ca4b806
https://hg.mozilla.org/mozilla-central/rev/7c5c4bce1b36
https://hg.mozilla.org/mozilla-central/rev/782e6df9b4c8
https://hg.mozilla.org/mozilla-central/rev/e805cbb61030
https://hg.mozilla.org/mozilla-central/rev/837b6ce8367b
https://hg.mozilla.org/mozilla-central/rev/e296aab6c841
https://hg.mozilla.org/mozilla-central/rev/258640cc1188
https://hg.mozilla.org/mozilla-central/rev/2b9472a516eb
https://hg.mozilla.org/mozilla-central/rev/cd6d06ee89dd
Description
•