Closed
Bug 1714914
Opened 3 years ago
Closed 3 years ago
Stop using `int32_t` for offset in parent node in editor module
Categories
(Core :: DOM: Editor, task, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Some methods in editor module still use int32_t for offset in parent node. However, for consistency with DOM API, it should be uint32_t.
|
Assignee | |
Comment 1•3 years ago
|
||
It should be treated as uint32_t since DOM API does so. However, there are
some exceptions:
- Result of
nsINode::ComputeIndexOf() - Result of
nsAStringmethods
They return -1 as not found, and anyway, they cannot treat large integer
than INT32_MAX. Therefore, this patch does not touch around them.
|
||
Updated•3 years ago
|
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/71670cedaf26
Make editor classes treat offset in parent node as uint32_t r=m_kato
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
|
Assignee | |
Updated•3 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•