Closed
Bug 1715209
Opened 3 years ago
Closed 3 years ago
geckodriver inappropriately kills Firefox during normal shutdown after all windows have been closed
Categories
(Testing :: geckodriver, defect)
Tracking
(firefox-esr78 unaffected, firefox89 unaffected, firefox90 unaffected, firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox89 | --- | unaffected |
| firefox90 | --- | unaffected |
| firefox91 | --- | fixed |
People
(Reporter: whimboo, Assigned: jgraham)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a regression from bug 1443520 where the code for handling special teardown logic in geckodriver has been refactored. As it can be seen in the following log the normal shutdown procedure is immediately aborted by just killing the underlying browser process.
https://treeherder.mozilla.org/logviewer?job_id=342063618&repo=mozilla-central&lineNumber=2649-2687
[task 2021-06-08T01:03:25.291Z] 01:03:25 INFO - PID 11076 | 1623114205289 Marionette DEBUG 0 -> [0,108,"Marionette:Quit",{"flags":["eForceQuit"]}]
[task 2021-06-08T01:03:25.292Z] 01:03:25 INFO - PID 11076 | 1623114205289 Marionette INFO Stopped listening on port 2828
[..]
[task 2021-06-08T01:03:25.400Z] 01:03:25 INFO - PID 11076 | 1623114205399 Marionette TRACE Received observer notification quit-application
[..]
[task 2021-06-08T01:03:25.406Z] 01:03:25 INFO - PID 11076 | 1623114205405 Marionette DEBUG 0 <- [1,108,null,{"cause":"shutdown","forced":false}]
[task 2021-06-08T01:03:25.454Z] 01:03:25 INFO - PID 11076 | 1623114205452 mozrunner::runner DEBUG Killing process 6984
[task 2021-06-08T01:03:25.457Z] 01:03:25 INFO - PID 11076 | DEBUG: Completed blocker ShieldRecipeClient: Cleaning up for phase profile-before-change
[task 2021-06-08T01:03:25.460Z] 01:03:25 INFO - PID 11076 | 1623114205456 webdriver::server DEBUG <- 200 OK {"value":[]}
|
Assignee | |
Comment 1•3 years ago
|
||
The arguments to map_or_else were the wrong way around. Since it's easier to read in this case
switch over to an explicit match statement.
|
||
Updated•3 years ago
|
Assignee: nobody → james
Status: NEW → ASSIGNED
|
|
||
Updated•3 years ago
|
Attachment #9225874 -
Attachment description: Bug 1715209 - Fix handling of implcit session delete return value, → Bug 1715209 - [geckodriver] Fix handling of implicit session delete return value.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/35524d037a22
[geckodriver] Fix handling of implicit session delete return value. r=webdriver-reviewers,whimboo
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
||
Updated•3 years ago
|
status-firefox89:
--- → unaffected
status-firefox-esr78:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•