Remove Task Tracer code from the profiler (but keep VTune)
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: canova, Assigned: florian)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Currently we have two features that we conditionally build. These are Vtune and Task Tracer and they are not maintained properly at the moment. It looks like we are still building the VTune most of the time, but it was actually failing when the MOZ_GECKO_PROFILER
wasn't defined.
Also, it's been a while since someone build the profiler with Task Tracer. I tried to build it today, and it can't even build right now due to some build errors.
I'm not so sure about VTune since someone can still be using that (please let us know if so!). Also, it may be okay since we still build it most of the time. In the meantime, I'm fixing the build errors by making it MOZ_GECKO_PROFILER
only. But I think it's safe to remove the Task Tracer. What do you think?
Comment 1•3 years ago
|
||
I'm fine with removing TaskTracer support. It is abandoned.
Comment 2•3 years ago
|
||
The JS team is still using VTune and is looking into using it more in the foreseeable future in order to evaluate some of our memory locality and code generation situation. Not sure what exactly the state is, but I suspect they'd prefer it not doing away. Iain?
Comment 3•3 years ago
|
||
Yeah, we don't use VTune often, but it's nice to have around. I tried it out in the shell a month or so ago, and it worked fine without any bitrot. I haven't tested out the profiler, but hopefully I can find some time to do so in the near-ish future.
If it's not causing any maintenance issues for the profiler team, the JS team would prefer keeping VTune support around.
Thanks everybody.
It looks like TaskTracer could go for sure, but VTune is still building and is occasionally useful.
So let's focus on TaskTracer in this bug.
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
After this lands, we should close all bugs related to the task tracer. Quick list (should be checked for other dependent bugs).
Comment 8•3 years ago
|
||
Comment 10•3 years ago
|
||
bugherder |
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Description
•