Closed
Bug 1715264
Opened 3 years ago
Closed 3 years ago
Fix test failures introduced by the Fission session restore work
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: u608768, Assigned: u608768)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
- browser/components/sessionstore/test/browser_async_flushes.js (disabled fission)
- browser/components/sessionstore/test/browser_async_remove_tab.js (disabled window/linux fission opt, but also previously disabled debug-only, so probably just an extremely flaky test)
- browser/components/sessionstore/test/browser_formdata.js (disabled for linux fission asan and mac fission)
- browser/components/sessionstore/test/browser_sessionHistory.js (disabled linux opt and windows fission)
Also worth noting that most of these weren't actually introduced by the Fission work, just worsened.
Summary: Fix intermittents introduced by the Fission session restore work → Fix test failures introduced by the Fission session restore work
I have fixes for all except browser_formdata.js, I'll fix that separately in bug 1703692.
No longer depends on: 1703692
This does a few things:
- Removes the
aImmediatelyflag from the RequestSHistoryUpdate path, and
moves that responsibility to SessionStore - Simplifies how and when SessionStore calls SessionHistory.collectFromParent()
- Attempts to clean-up SessionStore's SHistoryListener (again)
Depends on D117229
Relies on frame script message ordering.
Depends on D117231
Relies on frame script message ordering.
Depends on D117232
No longer depends on: 1536528
|
||
Comment 10•3 years ago
|
||
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/326db44229b0
Avoid flushing tab state for destroys triggered by process switches, r=nika
https://hg.mozilla.org/integration/autoland/rev/65bfa10b398e
Cleanup how Session Store collects SessionHistory, r=farre
https://hg.mozilla.org/integration/autoland/rev/965f1ec158db
Remove annotations for browser_sessionHistory.js, r=farre
https://hg.mozilla.org/integration/autoland/rev/12c99d8459a8
Fix browser_async_flushes.js for SHIP, r=farre
https://hg.mozilla.org/integration/autoland/rev/8af680e67714
Fix browser_async_remove_tab.js for SHIP, r=farre
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/326db44229b0
https://hg.mozilla.org/mozilla-central/rev/65bfa10b398e
https://hg.mozilla.org/mozilla-central/rev/965f1ec158db
https://hg.mozilla.org/mozilla-central/rev/12c99d8459a8
https://hg.mozilla.org/mozilla-central/rev/8af680e67714
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•