The bug count reports should be able to be stored along with queries.

I'm not convinced by this idea. I think that people should be using bookmarks (although I'm against the removal of stored queries.) Gerv

Why on Earth not - stored queries are much nicer than bookmarks, and this is exactly the same thing.

> stored queries are much nicer than bookmarks That's definitely a matter of opinion :-) Bookmarks can be easily managed, deleted, modified, hierarchically organised, given custom keywords, made into toolbars etc. using a native UI which supports nice things like drag and drop. We have to use HTML form controls, submit to a server on every change, and reinvent (poorly) all of those UI wheels. Gerv

*** Bug 178046 has been marked as a duplicate of this bug. ***

I am assigning all the bugs I am not working on in the immediate future to nobody@bugzilla.org. This means: - I will be able to search for bugs assigned to me as a list of bugs I'm going to fix (which is as it should be), and - people won't falsely assume I might be about to fix a bug when I'm not. Gerv

Using bookmarks requires you to use the same browser every time. A Saved report would allow you to log in from anywhere and still find your report.

Requiring users to use the same browser/computer every time is really a browser bug (bug 17048 for Mozilla), although that doesn't necessarily mean we shouldn't support a Bugzilla-specific workaround. Nevertheless, this feature *is* useful in at least one specific case: for sharing reports between user accounts.

I've done this in my customized Bugzilla, should be easy to port to the trunk (when I eventually get the chance).

hmm, seems like I found some time on this fine friday afternoon. Patch attached for 2.19.1-ish trunk

Comment on attachment 168986 [details] [diff] [review] rsiklos_v1 >+AddField('namedqueries', 'type', 'ENUM("query", "report") NOT NULL DEFAULT "query"'); Ewwwwwww, ENUM!! :( >Index: globals.pl >+sub LookupNamedQuery { report.cgi and buglist.cgi both use Search.pm, correct? Would it be possible to put this sub in Search.pm instead? Makes better sense there, and we're attempting to eliminate globals.pl before too long, so the more we can avoid putting new things there the better. I'm not denying review because that might stop other people from bothering to look at it, and I only glanced at it.

ok, no more enums, and moved LookupNamedQuery function to Search.pm

Comment on attachment 169309 [details] [diff] [review] rsiklos_v2 Removing r? from bitrotten patch.

de-bittrotted and now passes runtests.sh

Comment on attachment 174068 [details] [diff] [review] rsiklos_v3 Sorry for the delay. + SendSQL("DELETE FROM namedqueries WHERE userid = $userid AND name = $qname"); You're adding new code using SendSQL. Could you convert it to the new way of doing things (Bugzilla->dbh) ? That would be cool. Since we're at it, I also have two optional nits: - $::buffer = LookupNamedQuery($::FORM{"namedcmd"}); + $::buffer = Bugzilla::Search::LookupNamedQuery($::FORM{"namedcmd"}); I know it's not your code (old one), but having this on mod_perl would rock, so if you could ditch away the global variable, it would be nice. +[%# INTERFACE: + # (incomplete!) Again, I know it's not your code, but completing the interface would be cool. I have some free time this week (till Saturday); I can't promise to keep up on this bug after that, but I think I can help make some progress and test your v4/v5/etc if they are ready by then.

Ok, this one cleans up a bunch of holes, fixes some consistency and cosmetics, de-bitrots, and addresses the above nits (except for the complete interface).

Comment on attachment 196342 [details] [diff] [review] rsiklos_v4 This no longer applies cleanly to the trunk. Bitrotten (I wanted to take it for a spin today and I got a bunch of Hunk FAILED errors).

Duplicate of bug 319598 ?

Ah, yes, actually. I've done a lot of work on this in bug 319598, and I didn't find this bug when I was originally filing it. The current work is actually in bug 319598, so I'm duping this one to that one. *** This bug has been marked as a duplicate of 319598 ***